Skip to content

fix(notion): resolve custom page title properties #7323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BillLeoutsakosvl346 merged 1 commit into from
Sep 1, 2026
Merged

fix(notion): resolve custom page title properties #7323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/sim/lib/selectors/server/providers/notion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('Notion server selector adapter', () => {
object: 'page',
id: 'page-provider-id',
properties: {
Name: { type: 'title', title: [{ plain_text: 'Planning' }] },
Project: { type: 'title', title: [{ plain_text: 'Planning' }] },
},
}),
{ status: 200 }
Expand Down
27 changes: 3 additions & 24 deletions apps/sim/tools/notion/create_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { NotionCreatePageParams, NotionResponse } from '@/tools/notion/types'
import { PAGE_OUTPUT_PROPERTIES } from '@/tools/notion/types'
import { extractTitle } from '@/tools/notion/utils'
import type { ToolConfig } from '@/tools/types'

export const notionCreatePageTool: ToolConfig<NotionCreatePageParams, NotionResponse> = {
Expand Down Expand Up @@ -105,18 +106,7 @@ export const notionCreatePageTool: ToolConfig<NotionCreatePageParams, NotionResp

transformResponse: async (response: Response) => {
const data = await response.json()
let pageTitle = 'Untitled'

if (data.properties?.title) {
const titleProperty = data.properties.title
if (
titleProperty.title &&
Array.isArray(titleProperty.title) &&
titleProperty.title.length > 0
) {
pageTitle = titleProperty.title.map((t: any) => t.plain_text || '').join('')
}
}
const pageTitle = extractTitle(data.properties ?? {}) || 'Untitled'

return {
success: true,
Expand Down Expand Up @@ -178,18 +168,7 @@ export const notionCreatePageV2Tool: ToolConfig<

transformResponse: async (response: Response) => {
const data = await response.json()
let pageTitle = 'Untitled'

if (data.properties?.title) {
const titleProperty = data.properties.title
if (
titleProperty.title &&
Array.isArray(titleProperty.title) &&
titleProperty.title.length > 0
) {
pageTitle = titleProperty.title.map((t: any) => t.plain_text || '').join('')
}
}
const pageTitle = extractTitle(data.properties ?? {}) || 'Untitled'

return {
success: true,
Expand Down
28 changes: 3 additions & 25 deletions apps/sim/tools/notion/read.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { NotionReadParams, NotionResponse } from '@/tools/notion/types'
import { PAGE_OUTPUT_PROPERTIES } from '@/tools/notion/types'
import { extractTitle } from '@/tools/notion/utils'
import type { ToolConfig } from '@/tools/types'

export const notionReadTool: ToolConfig<NotionReadParams, NotionResponse> = {
Expand Down Expand Up @@ -49,19 +50,7 @@ export const notionReadTool: ToolConfig<NotionReadParams, NotionResponse> = {

transformResponse: async (response: Response, params?: NotionReadParams) => {
const data = await response.json()
let pageTitle = 'Untitled'

// Extract title from properties
if (data.properties?.title) {
const titleProperty = data.properties.title
if (
titleProperty.title &&
Array.isArray(titleProperty.title) &&
titleProperty.title.length > 0
) {
pageTitle = titleProperty.title.map((t: any) => t.plain_text || '').join('')
}
}
const pageTitle = extractTitle(data.properties ?? {}) || 'Untitled'

// Now fetch the page content using blocks endpoint
const pageId = params?.pageId?.trim()
Expand Down Expand Up @@ -199,18 +188,7 @@ export const notionReadV2Tool: ToolConfig<NotionReadParams, NotionReadV2Response

transformResponse: async (response: Response, params?: NotionReadParams) => {
const data = await response.json()
let pageTitle = 'Untitled'

if (data.properties?.title) {
const titleProperty = data.properties.title
if (
titleProperty.title &&
Array.isArray(titleProperty.title) &&
titleProperty.title.length > 0
) {
pageTitle = titleProperty.title.map((t: any) => t.plain_text || '').join('')
}
}
const pageTitle = extractTitle(data.properties ?? {}) || 'Untitled'

const pageId = params?.pageId?.trim()
const accessToken = params?.accessToken
Expand Down
63 changes: 63 additions & 0 deletions apps/sim/tools/notion/responses.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
/**
* @vitest-environment node
*/
import { describe, expect, it } from 'vitest'
import { notionCreatePageTool, notionCreatePageV2Tool } from '@/tools/notion/create_page'
import { notionReadTool, notionReadV2Tool } from '@/tools/notion/read'
import { notionUpdatePageTool, notionUpdatePageV2Tool } from '@/tools/notion/update_page'

const PAGE_TITLE = 'Project Apollo'

function pageResponse(): Response {
return Response.json({
id: 'page-1',
url: 'https://www.notion.so/page-1',
created_time: '2026-08-01T00:00:00.000Z',
last_edited_time: '2026-08-02T00:00:00.000Z',
properties: {
Project: {
id: 'title',
type: 'title',
title: [{ plain_text: PAGE_TITLE }],
},
},
})
}

const responseCases = [
{
id: notionReadTool.id,
title: async () =>
(await notionReadTool.transformResponse!(pageResponse())).output.metadata.title,
},
{
id: notionReadV2Tool.id,
title: async () => (await notionReadV2Tool.transformResponse!(pageResponse())).output.title,
},
{
id: notionCreatePageTool.id,
title: async () =>
(await notionCreatePageTool.transformResponse!(pageResponse())).output.metadata.title,
},
{
id: notionCreatePageV2Tool.id,
title: async () =>
(await notionCreatePageV2Tool.transformResponse!(pageResponse())).output.title,
},
{
id: notionUpdatePageTool.id,
title: async () =>
(await notionUpdatePageTool.transformResponse!(pageResponse())).output.metadata.title,
},
{
id: notionUpdatePageV2Tool.id,
title: async () =>
(await notionUpdatePageV2Tool.transformResponse!(pageResponse())).output.title,
},
]

describe('Notion page title responses', () => {
it.each(responseCases)('$id reads a custom-named title property', async ({ title }) => {
await expect(title()).resolves.toBe(PAGE_TITLE)
})
})
28 changes: 3 additions & 25 deletions apps/sim/tools/notion/update_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import type { NotionResponse, NotionUpdatePageParams } from '@/tools/notion/types'
import { PAGE_OUTPUT_PROPERTIES } from '@/tools/notion/types'
import { extractTitle } from '@/tools/notion/utils'
import type { ToolConfig } from '@/tools/types'

export const notionUpdatePageTool: ToolConfig<NotionUpdatePageParams, NotionResponse> = {
Expand Down Expand Up @@ -57,19 +58,7 @@ export const notionUpdatePageTool: ToolConfig<NotionUpdatePageParams, NotionResp

transformResponse: async (response: Response) => {
const data = await response.json()
let pageTitle = 'Untitled'

// Try to extract the title from properties
if (data.properties?.title) {
const titleProperty = data.properties.title
if (
titleProperty.title &&
Array.isArray(titleProperty.title) &&
titleProperty.title.length > 0
) {
pageTitle = titleProperty.title.map((t: any) => t.plain_text || '').join('')
}
}
const pageTitle = extractTitle(data.properties ?? {}) || 'Untitled'

return {
success: true,
Expand Down Expand Up @@ -133,18 +122,7 @@ export const notionUpdatePageV2Tool: ToolConfig<

transformResponse: async (response: Response) => {
const data = await response.json()
let pageTitle = 'Untitled'

if (data.properties?.title) {
const titleProperty = data.properties.title
if (
titleProperty.title &&
Array.isArray(titleProperty.title) &&
titleProperty.title.length > 0
) {
pageTitle = titleProperty.title.map((t: any) => t.plain_text || '').join('')
}
}
const pageTitle = extractTitle(data.properties ?? {}) || 'Untitled'

return {
success: true,
Expand Down
Loading