fix(notion): resolve custom page title properties - #7323
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
No issues found across 5 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.
Re-trigger cubic
Greptile SummaryThis PR updates all six Notion read, create, and update response transforms to resolve page titles by the property's
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, security, or compatibility issues identified. The shared extractor locates Notion’s single title-typed page property regardless of its user-defined name, preserves empty-title fallback behavior, and is applied consistently across legacy and V2 transforms.
|
| Filename | Overview |
|---|---|
| apps/sim/tools/notion/read.ts | Both read response formats now resolve custom-named title properties without altering content retrieval behavior. |
| apps/sim/tools/notion/create_page.ts | Legacy and V2 create responses consistently use the shared title extractor and retain the fallback. |
| apps/sim/tools/notion/update_page.ts | Legacy and V2 update responses consistently use the shared title extractor and retain the fallback. |
| apps/sim/tools/notion/responses.test.ts | Adds focused table-driven verification of custom title-property handling across all six transforms. |
| apps/sim/lib/selectors/server/providers/notion.test.ts | Verifies selector hydration against a custom-named primary title property. |
Reviews (1): Last reviewed commit: "fix(notion): resolve custom page title p..." | Re-trigger Greptile
Summary
Automated validation
All checks passed.
Browser validation
Using a disposable Notion database whose primary title property was renamed to Project:
The browser tooling did not expose the raw response body directly; normalized label behavior was verified through the rendered selector state, successful list/detail request logs, and focused adapter coverage.