Skip to content

fix(notion): resolve custom page title properties - #7323

Merged
BillLeoutsakosvl346 merged 1 commit into
stagingfrom
fix/notion-custom-title-properties
Sep 1, 2026
Merged

fix(notion): resolve custom page title properties#7323
BillLeoutsakosvl346 merged 1 commit into
stagingfrom
fix/notion-custom-title-properties

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • resolve Notion page titles by property type instead of a literal property key
  • preserve legacy and V2 response shapes and the existing Untitled fallback
  • cover custom-title selector hydration and all six read/create/update response transforms

Automated validation

  • bun run test -- lib/selectors/server/providers/notion.test.ts tools/notion/responses.test.ts
  • bunx biome check lib/selectors/server/providers/notion.test.ts tools/notion/read.ts tools/notion/create_page.ts tools/notion/update_page.ts tools/notion/responses.test.ts
  • bun run type-check
  • bun run check:api-validation

All checks passed.

Browser validation

Using a disposable Notion database whose primary title property was renamed to Project:

  • the page selector listed Sim Custom Title Row
  • saving and reloading the workflow hydrated the same selector label through the detail request
  • a Notion Read execution returned Sim Custom Title Row as its title
  • selector list and detail requests returned 200, with no related browser-console or server-log errors and no credentials exposed

The browser tooling did not expose the raw response body directly; normalized label behavior was verified through the rendered selector state, successful list/detail request logs, and focused adapter coverage.

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 1, 2026 12:21am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’re close to your included review allowance. Set a flex budget so reviews don’t pause.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates all six Notion read, create, and update response transforms to resolve page titles by the property's title type rather than a literal property key, while preserving the Untitled fallback.

  • Reuses the shared extractTitle helper across legacy and V2 response adapters.
  • Adds table-driven coverage for custom-named title properties.
  • Updates selector coverage to use a renamed primary title property.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or compatibility issues identified.

The shared extractor locates Notion’s single title-typed page property regardless of its user-defined name, preserves empty-title fallback behavior, and is applied consistently across legacy and V2 transforms.

Important Files Changed

Filename Overview
apps/sim/tools/notion/read.ts Both read response formats now resolve custom-named title properties without altering content retrieval behavior.
apps/sim/tools/notion/create_page.ts Legacy and V2 create responses consistently use the shared title extractor and retain the fallback.
apps/sim/tools/notion/update_page.ts Legacy and V2 update responses consistently use the shared title extractor and retain the fallback.
apps/sim/tools/notion/responses.test.ts Adds focused table-driven verification of custom title-property handling across all six transforms.
apps/sim/lib/selectors/server/providers/notion.test.ts Verifies selector hydration against a custom-named primary title property.

Reviews (1): Last reviewed commit: "fix(notion): resolve custom page title p..." | Re-trigger Greptile

@BillLeoutsakosvl346
BillLeoutsakosvl346 merged commit 04f7cd2 into staging Sep 1, 2026
27 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/notion-custom-title-properties branch September 1, 2026 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant