Skip to content

improvement(files): fill the active find match instead of ringing it #7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Aug 28, 2026
+11 −3
Merged

improvement(files): fill the active find match instead of ringing it #7198

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .../[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,14 +587,22 @@
}

/* Cmd/Ctrl+F match highlights. Every hit carries the same tint the rest of the app
* paints a search match with; the active one is ringed rather than recolored, so the
* two read as one family and neither needs a token that only exists here. */
* paints a search match with. */
.rich-markdown-nodes .rich-find-match {
background-color: var(--highlight-match-bg);
color: var(--highlight-match-text);
border-radius: 2px;
}

/* The active hit is a stronger fill of the same hue, never a ring: an outline drawn
* around a run of text traces the line box, so on a heading it reads as a stray
* rectangle rather than as emphasis. Filling instead keeps the two states one family.
*
* The ink is fixed rather than tokenized because the fill is: `--brand-secondary` is
* the same blue in both themes, so a theme-flipping text token would go white on light
* blue in dark mode. Same reasoning as the note card's active search mark, which pairs
* its solid fill with a fixed dark ink for exactly this reason. */
.rich-markdown-nodes .rich-find-match-active {
box-shadow: 0 0 0 1.5px var(--highlight-match-text);
background-color: var(--brand-secondary);
color: #000;
}
Loading