Skip to content

improvement(files): fill the active find match instead of ringing it - #7198

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/find-brand-alignment
Aug 28, 2026
Merged

improvement(files): fill the active find match instead of ringing it#7198
waleedlatif1 merged 1 commit into
stagingfrom
improvement/find-brand-alignment

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • The Cmd/Ctrl+F active match was drawn as a 1.5px ring in --highlight-match-text. An outline around a run of text traces its line box, so on a heading it read as a stray dark rectangle rather than as emphasis — and a match wrapping across two lines drew two disjoint boxes
  • The active hit is now a solid --brand-secondary fill with a fixed dark ink, so it stays in the same family as the inactive tint and wraps cleanly
  • The ink is fixed rather than tokenized because the fill is: --brand-secondary is the same blue in both themes, so a theme-flipping text token would go white on light blue in dark mode. Same pairing the note card's active search mark already uses

Type of Change

  • Improvement

Testing

Rendered the real component stylesheet against the app's real tokens in both themes (headless Chromium) and compared four candidate treatments before picking this one — including a heading, a match inside inline code, a match spanning bold, and a match wrapping across two lines.

bun run lint (26/26), bun run check:audits (37/37), bun run type-check, and 593 rich-markdown-editor tests all pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

The Cmd/Ctrl+F active match was drawn as a 1.5px ring in --highlight-match-text.
An outline around a run of text traces its line box, so on a heading it read as a
stray dark rectangle rather than as emphasis, and a match wrapping across two
lines drew two disjoint boxes.

The active hit is now a solid --brand-secondary fill with a fixed dark ink, so it
stays in the same family as the inactive tint and wraps cleanly. The ink is fixed
rather than tokenized because the fill is: --brand-secondary is the same blue in
both themes, so a theme-flipping text token would go white on light blue in dark
mode. Same pairing the note card's active search mark already uses.
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 28, 2026 4:54am

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR replaces the active rich-markdown find result’s outline with a solid brand-blue fill and fixed black text.

  • Keeps inactive matches on the existing highlight tokens.
  • Makes wrapped and heading matches render as filled text runs instead of disjoint line-box outlines.
  • Uses the same --brand-secondary value across light and dark themes.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness, accessibility, or styling issue identified.

The active and inactive match states remain visually distinct in both configured themes, the new foreground has strong contrast against the shared brand-blue fill, and the referenced CSS variable is defined consistently.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.css Replaces the active find-match ring with a readable, theme-consistent solid fill; no actionable defect was identified.

Reviews (1): Last reviewed commit: "improvement(files): fill the active find..." | Re-trigger Greptile

@waleedlatif1
waleedlatif1 merged commit 1969779 into staging Aug 28, 2026
21 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/find-brand-alignment branch August 28, 2026 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant