improvement(files): fill the active find match instead of ringing it - #7198
Conversation
The Cmd/Ctrl+F active match was drawn as a 1.5px ring in --highlight-match-text. An outline around a run of text traces its line box, so on a heading it read as a stray dark rectangle rather than as emphasis, and a match wrapping across two lines drew two disjoint boxes. The active hit is now a solid --brand-secondary fill with a fixed dark ink, so it stays in the same family as the inactive tint and wraps cleanly. The ink is fixed rather than tokenized because the fill is: --brand-secondary is the same blue in both themes, so a theme-flipping text token would go white on light blue in dark mode. Same pairing the note card's active search mark already uses.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Greptile SummaryThe PR replaces the active rich-markdown find result’s outline with a solid brand-blue fill and fixed black text.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness, accessibility, or styling issue identified. The active and inactive match states remain visually distinct in both configured themes, the new foreground has strong contrast against the shared brand-blue fill, and the referenced CSS variable is defined consistently.
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/files/components/file-viewer/rich-markdown-editor/rich-markdown-editor.css | Replaces the active find-match ring with a readable, theme-consistent solid fill; no actionable defect was identified. |
Reviews (1): Last reviewed commit: "improvement(files): fill the active find..." | Re-trigger Greptile
Summary
--highlight-match-text. An outline around a run of text traces its line box, so on a heading it read as a stray dark rectangle rather than as emphasis — and a match wrapping across two lines drew two disjoint boxes--brand-secondaryfill with a fixed dark ink, so it stays in the same family as the inactive tint and wraps cleanly--brand-secondaryis the same blue in both themes, so a theme-flipping text token would go white on light blue in dark mode. Same pairing the note card's active search mark already usesType of Change
Testing
Rendered the real component stylesheet against the app's real tokens in both themes (headless Chromium) and compared four candidate treatments before picking this one — including a heading, a match inside inline code, a match spanning bold, and a match wrapping across two lines.
bun run lint(26/26),bun run check:audits(37/37),bun run type-check, and 593 rich-markdown-editor tests all pass.Checklist