fix(android): reject invalid manifest XML before parsing - #2844
Draft
OskarEichler wants to merge 1 commit into
Draft
fix(android): reject invalid manifest XML before parsing#2844OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This was referenced Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix and blocking follow-up
XMLValidator.validate()returns eithertrueor an error object. The current truthiness check accepts the error object, so malformed manifests are parsed as if validation succeeded. Require an actualtrueresult.Draft, not ready to merge or consume: the existing multi-activity fixture contains an unmatched
</queries>closing tag. This fix correctly rejects it, leaving the unchanged focused upstream suite at 4 passed / 1 failed. The fixture needs correction in a separately authorized upstream change; no test file or assertion was changed here. This patch is excluded from our app's adoption candidate.Compatibility
Malformed manifests now return
nullinstead of occasionally yielding a launcher from partially parsed XML. Valid manifests retain existing behavior. No dependency or SDK version change.Verification
9013a480c66aece0e23cc8082ee23f92274e3cf4.Type: fix