fix(android): preserve device profiles, task paths and command context - #2834
Open
OskarEichler wants to merge 1 commit into
Open
fix(android): preserve device profiles, task paths and command context#2834OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Use argv-based ADB discovery without grep; preserve ABI fallback; install and launch under the selected user including 0; query profiles after emulator launch; preserve caller cwd and project config; reject missing selected devices; retain qualified Gradle task paths; locate interactive flavor APKs with correct casing; validate binary paths before starting Metro.
Compatibility and observable changes
Missing selected devices now reject instead of reporting success. --user applies consistently to installation and launch. Existing emulator framework-readiness PR #2830 is not duplicated. No native SDK or runtime dependency upgrade.
Verification
9013a480c66aece0e23cc8082ee23f92274e3cf4; 22 focused actual-source controls passed. The published tree matches the independently verified local tree exactly, including executable permissions.OskarEichler/cli): CLIde1aabb75931032240c3b9daefc0cf77276935cd; platform Android0d92368fb31e92edbea9bfb002392c891688bd82; config5ef410e4f719a4ab87591b01ebfbacf1d18fa8be; config Android946a49e5ad888b535274ff1d7977e680683a0d38; toolsc05d7c087c4c14a736b8a6f82ce10f0e340a05b6. These are package artifacts, not additional source changes in this PR.Type: fix
No React Native, native SDK, or package version bump is included.