Skip to content

tui: migrate remaining layouts to Grid - #962

Open
Michael Greene (mgreenegit) wants to merge 1 commit into
microsoft:mainfrom
mgreenegit:fix/migrate-grid-callers
Open

Michael Greene (mgreenegit) wants to merge 1 commit into
microsoft:mainfrom
mgreenegit:fix/migrate-grid-callers

Conversation

@mgreenegit

@mgreenegit Michael Greene (mgreenegit) commented Sep 22, 2026

Copy link
Copy Markdown
Member

Review boundary

Final slice: migrate callers and remove the table API. Review/merge order: #950 -> #961 -> #962.

Review only this slice: 192 additions / 123 deletions across six files (315 changed lines, down from 329). The comparison uses a content-identical linear review snapshot; this PR retains one cumulative commit against main, including both unmerged prerequisites.

Changes

  • Migrate all 11 table-construction sites: search/replace, action groups, file-picker forms, statusbar/indentation/encoding controls, menubar, and flyouts.
  • Use declarative shared rows, intrinsic sizing, gaps, and navigation while preserving focus hierarchy, row identity, floats, and hitboxes. Omit 14 redundant settings where defaults suffice.
  • Use fractional fill columns in constrained search/file-picker forms; retain unrelated sizing sentinels.
  • Delete the table API. Shared layout algorithms and generic Grid tests are unchanged from tui: unify layout through boxed Grid subgrids #961.
  • Extend the existing application scenario for dialog Tab/ShiftTab/arrow navigation and file-picker alignment, typing, cancellation, and restored editor focus.

This pull request was drafted by a large language model (LLM).

Validation

  • Latest local validation: nine Grid tests and two application layout tests pass, along with formatting, pre-commit workspace Clippy, and scoped structural checks.
  • The TUI-only optimization is carried forward unchanged from tui: unify layout through boxed Grid subgrids #961; this slice's incremental scope and all tests are unchanged.
  • Source comparisons confirm unchanged shared algorithms/tests and no remaining table API calls or content variants.
  • Final-head Windows/Ubuntu CI and CodeQL pass at c33ecee.

This completes the existing table migration, not full CSS support. No Flexbox, arbitrary spans, stylesheet parser, console/provider/AI work, or new dependencies.

@mgreenegit
Michael Greene (mgreenegit) marked this pull request as ready for review September 22, 2026 14:51
Michael Greene (mgreenegit) added a commit to mgreenegit/edit that referenced this pull request Sep 22, 2026
Include the Grid prerequisite from microsoft#950 and route existing table declarations through the durable shared engine. Preserve interactive boxed rows, intrinsic sizing, gaps, and navigation with generic Grid properties. Application caller migration remains in microsoft#962.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Greene (mgreenegit) added a commit to mgreenegit/edit that referenced this pull request Sep 22, 2026
Add typed row and column tracks with shared sizing and bounded placement, and adopt Grid for the viewport and editor. Cover layout geometry, resizing, focus, and existing menu interaction without changing legacy table callers. First slice of microsoft#950, microsoft#961, and microsoft#962.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Include the Grid prerequisites, replace table callers with declarative boxed rows, and remove compatibility APIs. Carry the compact placement and horizontal-inset helpers forward unchanged from the shared-engine slice.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant