tui: migrate remaining layouts to Grid - #962
Open
Michael Greene (mgreenegit) wants to merge 1 commit into
Open
Michael Greene (mgreenegit) wants to merge 1 commit into
Michael Greene (mgreenegit) wants to merge 1 commit into
Conversation
Michael Greene (mgreenegit)
marked this pull request as ready for review
September 22, 2026 14:51
Michael Greene (mgreenegit)
added a commit
to mgreenegit/edit
that referenced
this pull request
Sep 22, 2026
Include the Grid prerequisite from microsoft#950 and route existing table declarations through the durable shared engine. Preserve interactive boxed rows, intrinsic sizing, gaps, and navigation with generic Grid properties. Application caller migration remains in microsoft#962. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Greene (mgreenegit)
force-pushed
the
fix/migrate-grid-callers
branch
from
September 22, 2026 14:57
e07a857 to
a889c29
Compare
Michael Greene (mgreenegit)
added a commit
to mgreenegit/edit
that referenced
this pull request
Sep 22, 2026
Add typed row and column tracks with shared sizing and bounded placement, and adopt Grid for the viewport and editor. Cover layout geometry, resizing, focus, and existing menu interaction without changing legacy table callers. First slice of microsoft#950, microsoft#961, and microsoft#962. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Greene (mgreenegit)
force-pushed
the
fix/migrate-grid-callers
branch
from
September 22, 2026 15:18
a889c29 to
5fd0a8a
Compare
Include the Grid prerequisites, replace table callers with declarative boxed rows, and remove compatibility APIs. Carry the compact placement and horizontal-inset helpers forward unchanged from the shared-engine slice. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Greene (mgreenegit)
force-pushed
the
fix/migrate-grid-callers
branch
from
September 22, 2026 15:36
5fd0a8a to
c33ecee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review boundary
Final slice: migrate callers and remove the table API. Review/merge order: #950 -> #961 -> #962.
Review only this slice: 192 additions / 123 deletions across six files (315 changed lines, down from 329). The comparison uses a content-identical linear review snapshot; this PR retains one cumulative commit against
main, including both unmerged prerequisites.Changes
This pull request was drafted by a large language model (LLM).
Validation
c33ecee.This completes the existing table migration, not full CSS support. No Flexbox, arbitrary spans, stylesheet parser, console/provider/AI work, or new dependencies.