tui: unify layout through boxed Grid subgrids - #961
Open
Michael Greene (mgreenegit) wants to merge 1 commit into
Open
Michael Greene (mgreenegit) wants to merge 1 commit into
Michael Greene (mgreenegit) wants to merge 1 commit into
Conversation
Michael Greene (mgreenegit)
marked this pull request as ready for review
September 22, 2026 02:04
Michael Greene (mgreenegit)
marked this pull request as draft
September 22, 2026 02:30
This was referenced Sep 22, 2026
Michael Greene (mgreenegit)
marked this pull request as ready for review
September 22, 2026 14:51
Michael Greene (mgreenegit)
added a commit
to mgreenegit/edit
that referenced
this pull request
Sep 22, 2026
Include the Grid prerequisites from microsoft#950 and microsoft#961, migrate all remaining table callers to explicit Grid declarations, and remove the compatibility API. Preserve shared engine algorithms and generic regressions from the second slice while checking dialog and file-picker focus restoration. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Greene (mgreenegit)
force-pushed
the
fix/unify-grid-table-layout
branch
from
September 22, 2026 14:57
4ceda3f to
fcbd8ba
Compare
Michael Greene (mgreenegit)
added a commit
to mgreenegit/edit
that referenced
this pull request
Sep 22, 2026
Add typed row and column tracks with shared sizing and bounded placement, and adopt Grid for the viewport and editor. Cover layout geometry, resizing, focus, and existing menu interaction without changing legacy table callers. First slice of microsoft#950, microsoft#961, and microsoft#962. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Greene (mgreenegit)
force-pushed
the
fix/unify-grid-table-layout
branch
from
September 22, 2026 15:18
fcbd8ba to
1777380
Compare
Route existing table declarations through the lasting shared engine. Extend the first slice item-placement helper and compute only the horizontal insets needed by shared columns, retaining geometry and navigation coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Michael Greene (mgreenegit)
force-pushed
the
fix/unify-grid-table-layout
branch
from
September 22, 2026 15:36
1777380 to
d333592
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review boundary
Second slice: the lasting shared layout engine, with application callers unchanged. Review/merge order: #950 -> #961 -> #962.
Review only this slice: 494 additions / 198 deletions across two files (692 changed lines, down from 742). The comparison uses a content-identical linear review snapshot; this PR itself retains one cumulative commit against
main, including unmerged #950.Changes
This is a terminal Grid subset: subgrids occupy a complete parent row; nested column subgrids and arbitrary spans are unsupported. Ordinary nested grids work. Row borders/padding contribute to sizing and clip cells to row interiors.
This pull request was drafted by a large language model (LLM).
Validation
d333592.No dependencies, Flexbox, stylesheet parser, console, provider, or AI changes.