Use SPDX license identifier in package metadata - #2687
Conversation
Sets license to "Apache-2.0" instead of "Apache License Version 2.0", and drops the deprecated "License :: OSI Approved :: Apache Software License" classifier, per PEP 639. Does the same in setup-asyncio.py and setup-release.py, which carried the same values as setup.py.
|
|
|
Welcome @chala2001! |
|
thanks for the PR /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chala2001, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
91fd167
into
kubernetes-client:master
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Sets the license metadata to the SPDX identifier
Apache-2.0instead of the freetext
Apache License Version 2.0, and drops the deprecatedLicense :: OSI Approved :: Apache Software Licenseclassifier, per PEP 639.The diff in the issue covers
setup.py.setup-asyncio.pyandsetup-release.pycarried the same two values, so I changed those too - otherwise the asyncio and
release builds would keep emitting the old metadata.
Checked the generated metadata with setuptools 84.0.0, before and after:
One thing worth flagging:
setup(license="Apache-2.0")still lands in the legacyLicensefield rather than PEP 639'sLicense-Expression. The value is a validSPDX identifier now and the deprecated classifier is gone, which is what the issue
asks for, but a real
License-Expressionwould need apyproject.tomlwith[project] license. Happy to do that as a follow-up if you want it.Which issue(s) this PR fixes:
Fixes #2686
Special notes for your reviewer:
Packaging metadata only, no code or behaviour changes.
Does this PR introduce a user-facing change?