Skip to content

Use SPDX license identifier in package metadata - #2687

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:masterfrom
chala2001:spdx-license-metadata
Aug 27, 2026
Merged

Use SPDX license identifier in package metadata#2687
kubernetes-prow[bot] merged 1 commit into
kubernetes-client:masterfrom
chala2001:spdx-license-metadata

Conversation

@chala2001

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Sets the license metadata to the SPDX identifier Apache-2.0 instead of the free
text Apache License Version 2.0, and drops the deprecated
License :: OSI Approved :: Apache Software License classifier, per PEP 639.

The diff in the issue covers setup.py. setup-asyncio.py and setup-release.py
carried the same two values, so I changed those too - otherwise the asyncio and
release builds would keep emitting the old metadata.

Checked the generated metadata with setuptools 84.0.0, before and after:

before:  License: Apache License Version 2.0
         Classifier: License :: OSI Approved :: Apache Software License

after:   License: Apache-2.0

One thing worth flagging: setup(license="Apache-2.0") still lands in the legacy
License field rather than PEP 639's License-Expression. The value is a valid
SPDX identifier now and the deprecated classifier is gone, which is what the issue
asks for, but a real License-Expression would need a pyproject.toml with
[project] license. Happy to do that as a follow-up if you want it.

Which issue(s) this PR fixes:

Fixes #2686

Special notes for your reviewer:

Packaging metadata only, no code or behaviour changes.

Does this PR introduce a user-facing change?

Package license metadata now uses the SPDX identifier `Apache-2.0`, and the deprecated Apache Software License classifier has been removed.

Sets license to "Apache-2.0" instead of "Apache License Version 2.0", and
drops the deprecated "License :: OSI Approved :: Apache Software License"
classifier, per PEP 639.

Does the same in setup-asyncio.py and setup-release.py, which carried the
same values as setup.py.
@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 27, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Aug 27, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: chala2001 / name: chala2001 (c2dd7d1)

@kubernetes-prow

Copy link
Copy Markdown
Contributor

Welcome @chala2001!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow kubernetes-prow Bot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from roycaihw and yliaog August 27, 2026 12:06
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 27, 2026
@yliaog

yliaog commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

thanks for the PR
please follow up on pyproject.toml with [project] license

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chala2001, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 91fd167 into kubernetes-client:master Aug 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

License metadata is not SPDX-compliant

2 participants