Use setuptools license_expression for the license metadata - #2688
Merged
kubernetes-prow[bot] merged 1 commit intoAug 28, 2026
Merged
Conversation
Contributor
|
please use setuptools' license_expression= keyword in setup() instead, thanks. |
chala2001
force-pushed
the
pyproject-license-expression
branch
from
August 28, 2026 02:27
0500587 to
8bedad9
Compare
Contributor
Author
|
Done - switched to |
Contributor
|
thanks for the PR /lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chala2001, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
merged commit Aug 28, 2026
fa09746
into
kubernetes-client:master
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Follow-up to #2687, as requested there.
#2687 set the license to the SPDX identifier
Apache-2.0, but a plainlicense=keyword lands in the legacy free-text
Licensefield. setuptools'license_expression=keyword produces the PEP 639License-Expressionfieldinstead, so that is what the three setup scripts now use.
Metadata built with setuptools 84.0.0:
Checked all three scripts, and the distribution names are unchanged:
License-File: LICENSEis still there, and the legacyLicensefield is gone.pip install -e ., which is whattoxdoes viausedevelop = True, still works.Which issue(s) this PR fixes:
Follow-up to #2687, no separate issue.
Special notes for your reviewer:
license_expression=needs setuptools 77 or newer. Older versions ignore it with awarning rather than failing, so an old build environment gets the same metadata it
gets today.
An earlier version of this PR added a
pyproject.tomlwith[project] license.That worked, but
[project] namecannot bedynamic, so it renamed thesetup-asyncio.pybuild fromkubernetes.aiotokubernetes. The keyword routeyou asked for avoids that entirely and is three lines instead of a new file.
Does this PR introduce a user-facing change?