-
Notifications
You must be signed in to change notification settings - Fork 0
feat(indexes): add vector_precision field to index operations #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hotdata-automation
wants to merge
1
commit into
main
Choose a base branch
from
openapi-update-35110464475
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document the breaking API changes in this Unreleased section.
scripts/update_changelog.py:15-19copies the Unreleased body verbatim into the released section. So this single line becomes the whole release note.The diff breaks three parts of the public API:
key_determinesis gone fromAddManagedTableDecl,AddManagedTableRequestandDatabaseDefaultTableDecl, replaced byconstant_per_key.TableInfo::newtakes a new requiredconstant_per_key: Vec<String>argument.JobTypegains theTableConstantsUpdatevariant, which breaks an exhaustivematchdownstream.Failure scenario: a caller on 0.18.0 sets
key_determineson a table declaration. That field was announced as a feature inCHANGELOG.md:73. After upgrading, the caller fails to compile withno field named key_determines. The release notes mention onlyvector_precision, so the caller has no migration path.Add a
### Removedor**Breaking:**entry in the style ofCHANGELOG.md:37andCHANGELOG.md:85. Name the old and the new field. The semver policy atCHANGELOG.md:6also makes this a minor bump, not the patch bump thatRELEASING.md:66describes for regeneration.Also list the other new surface: the two
constant-per-keyendpoints,vector_precisiononCreateIndexRequest,IndexInfoResponseandIndexEntryResponse, andTableInfo.constant_per_key.