Skip to content

feat(indexes): add vector_precision field to index operations - #145

Open
hotdata-automation[bot] wants to merge 1 commit into
mainfrom
openapi-update-35110464475
Open

hotdata-automation[bot] wants to merge 1 commit into
mainfrom
openapi-update-35110464475

Conversation

@hotdata-automation

Copy link
Copy Markdown
Contributor

Auto-generated from the updated HotData OpenAPI spec.
Source: https://github.com/hotdata-dev/www/pull/428

@hotdata-automation
hotdata-automation Bot requested a review from a team as a code owner September 16, 2026 14:43
@hotdata-automation
hotdata-automation Bot removed the request for review from a team September 16, 2026 14:43
@hotdata-automation
hotdata-automation Bot enabled auto-merge (squash) September 16, 2026 14:43
Comment thread CHANGELOG.md

### Changed

- feat(indexes): add vector_precision field to index operations

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document the breaking API changes in this Unreleased section.

scripts/update_changelog.py:15-19 copies the Unreleased body verbatim into the released section. So this single line becomes the whole release note.

The diff breaks three parts of the public API:

  • key_determines is gone from AddManagedTableDecl, AddManagedTableRequest and DatabaseDefaultTableDecl, replaced by constant_per_key.
  • TableInfo::new takes a new required constant_per_key: Vec<String> argument.
  • JobType gains the TableConstantsUpdate variant, which breaks an exhaustive match downstream.

Failure scenario: a caller on 0.18.0 sets key_determines on a table declaration. That field was announced as a feature in CHANGELOG.md:73. After upgrading, the caller fails to compile with no field named key_determines. The release notes mention only vector_precision, so the caller has no migration path.

Add a ### Removed or **Breaking:** entry in the style of CHANGELOG.md:37 and CHANGELOG.md:85. Name the old and the new field. The semver policy at CHANGELOG.md:6 also makes this a minor bump, not the patch bump that RELEASING.md:66 describes for regeneration.

Also list the other new surface: the two constant-per-key endpoints, vector_precision on CreateIndexRequest, IndexInfoResponse and IndexEntryResponse, and TableInfo.constant_per_key.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Blocking Issues

  • CHANGELOG.md:12 records only the vector_precision addition. The diff also removes key_determines from three request models, adds a required argument to TableInfo::new, and adds a JobType variant. All three break callers of 0.18.0.

Action Required

  • Rewrite the Unreleased body to name the breaking changes, following the **Breaking:** style used at CHANGELOG.md:37 and CHANGELOG.md:85.
  • List the new surface too: the two constant-per-key endpoints, vector_precision on the index request and responses, and TableInfo.constant_per_key.

Notes

  • No hand-written code in src/, tests/ or examples/ references key_determines or TableInfo::new, so the crate itself still builds.
  • Integration Tests / integration was still running when this review started. TableInfo.constant_per_key is required with no serde default, so that job fails if the API under test omits the field.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants