-
Notifications
You must be signed in to change notification settings - Fork 10
docs(ingest): name iggy wherever the family lists are spelled #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+11
−10
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -228,8 +228,8 @@ pub enum IngestCommands { | |||||||||||||||||||||||||||
| dest_table: Option<String>, | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
| /// Common prefix for the destination tables of a source that lands | ||||||||||||||||||||||||||||
| /// SEVERAL: SQL --table/--sql, Iceberg, DuckLake, Kafka, REST. Each | ||||||||||||||||||||||||||||
| /// source table `orders` lands as `<prefix>_orders`. | ||||||||||||||||||||||||||||
| /// SEVERAL: SQL --table/--sql, Iceberg, DuckLake, Kafka, Iggy, REST. | ||||||||||||||||||||||||||||
| /// Each source table `orders` lands as `<prefix>_orders`. | ||||||||||||||||||||||||||||
| /// | ||||||||||||||||||||||||||||
| /// Optional. Without it the source names are used unchanged, which is | ||||||||||||||||||||||||||||
| /// what a raw mirror of a schema or a catalog wants — but only one | ||||||||||||||||||||||||||||
|
|
@@ -839,8 +839,9 @@ fn build_selector(plan: &CreatePlan) -> Result<(serde_json::Value, Option<String | |||||||||||||||||||||||||||
| if selector.is_empty() { | ||||||||||||||||||||||||||||
| return Err( | ||||||||||||||||||||||||||||
| "nothing to read — pass --table <name> (SQL, Iceberg, DuckLake), --table-path \ | ||||||||||||||||||||||||||||
| <path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an optional --glob \ | ||||||||||||||||||||||||||||
| (buckets), --sql, --raw-sql, --all, or the whole --selector as JSON. A REST \ | ||||||||||||||||||||||||||||
| <path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an \ | ||||||||||||||||||||||||||||
| optional --glob (buckets), --sql, --raw-sql, --all, or the whole --selector as \ | ||||||||||||||||||||||||||||
| JSON. A REST \ | ||||||||||||||||||||||||||||
| source is --selector only: its resources carry endpoints, not just names \ | ||||||||||||||||||||||||||||
| ('hotdata ingest sources fields rest')" | ||||||||||||||||||||||||||||
|
Comment on lines
841
to
846
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. super nit: the rewrap leaves
Suggested change
|
||||||||||||||||||||||||||||
| .into(), | ||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: one more copy of this same list still omits Iggy (not blocking).
src/client/ingest.rs:167prints the multi-table family list in theinvalid_destinationerror hint:(SQL --table/--sql, Iceberg, DuckLake, Kafka, REST). That line is outside this diff, so a suggestion block cannot reach it.A user who passes
--dest-tablewith an Iggy source hits that hint and reads a list that excludes Iggy. The hint then contradicts this--helptext andskills/hotdata/SKILL.md:393. AddIggyafterKafkathere for the same reason the other two lists changed.