Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions skills/hotdata/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -384,13 +384,13 @@ hotdata ingest create --source "prod postgres" --table orders --schema public \
# --stream shorthand for --type continuous (still needs --every).
# Offered only where `hotdata ingest sources fields
# <family>` says `continuous: yes` — today filesystem,
# derived, kafka, iggy; the server refuses it elsewhere.
# kafka, iggy; the server refuses it elsewhere.
# Destination flags instead of --destination:
# --database-id (required) --dest-schema (default public) --write-mode (default replace)
# --dest-table <name> for sources that land ONE table: buckets, delta,
# --raw-sql (defaults to --table there)
# --dest-table-prefix <p> for sources that land SEVERAL (sql --table/--sql,
# iceberg, ducklake, kafka, rest): `orders` lands as
# iceberg, ducklake, kafka, iggy, rest): `orders` lands as
# `<p>_orders`. Optional, but only one prefix-less
# ingest can own a database+schema — a second one
# must pick a prefix or it overwrites the first.
Expand Down
8 changes: 4 additions & 4 deletions src/commands/datasource.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ pub enum DatasourceCommands {
#[command(name = "test")]
Validate {
/// Source family — the shape of --config: sql, filesystem, iceberg,
/// delta, ducklake, kafka, rest. Use `sql` for any SQL dialect (the
/// delta, ducklake, kafka, iggy, rest. Use `sql` for any SQL dialect (the
/// dialect goes in the config) and `filesystem` for buckets.
///
/// Not validated here on purpose: the service decides which families
Expand Down Expand Up @@ -93,7 +93,7 @@ pub enum DatasourceCommands {
#[command(name = "add")]
Create {
/// Source family — the shape of --config: sql, filesystem, iceberg,
/// delta, ducklake, kafka, rest. Use `sql` for any SQL dialect (the
/// delta, ducklake, kafka, iggy, rest. Use `sql` for any SQL dialect (the
/// dialect goes in the config) and `filesystem` for buckets.
///
/// Omit it on a terminal to pick a source type from the catalog.
Expand Down Expand Up @@ -184,7 +184,7 @@ pub enum DatasourceCommands {
/// script to build a form from.
Fields {
/// Family to describe — the FAMILY column of `hotdata ingest sources
/// types`, e.g. sql, filesystem, iceberg, kafka, rest
/// types`, e.g. sql, filesystem, iceberg, kafka, iggy, rest
family: Option<String>,
},
}
Expand Down Expand Up @@ -509,7 +509,7 @@ fn create(
let from_flags = (!payload.is_empty() || !util::is_interactive()).then(|| {
let Some(family) = family else {
fail(
"--family is required (sql, filesystem, iceberg, delta, ducklake, kafka, rest). \
"--family is required (sql, filesystem, iceberg, delta, ducklake, kafka, iggy, rest). \
Run 'hotdata ingest sources add' in a terminal to be asked instead.",
);
};
Expand Down
9 changes: 5 additions & 4 deletions src/commands/ingest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ pub enum IngestCommands {
dest_table: Option<String>,

/// Common prefix for the destination tables of a source that lands
/// SEVERAL: SQL --table/--sql, Iceberg, DuckLake, Kafka, REST. Each
/// source table `orders` lands as `<prefix>_orders`.
/// SEVERAL: SQL --table/--sql, Iceberg, DuckLake, Kafka, Iggy, REST.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: one more copy of this same list still omits Iggy (not blocking).

src/client/ingest.rs:167 prints the multi-table family list in the invalid_destination error hint: (SQL --table/--sql, Iceberg, DuckLake, Kafka, REST). That line is outside this diff, so a suggestion block cannot reach it.

A user who passes --dest-table with an Iggy source hits that hint and reads a list that excludes Iggy. The hint then contradicts this --help text and skills/hotdata/SKILL.md:393. Add Iggy after Kafka there for the same reason the other two lists changed.

/// Each source table `orders` lands as `<prefix>_orders`.
///
/// Optional. Without it the source names are used unchanged, which is
/// what a raw mirror of a schema or a catalog wants — but only one
Expand Down Expand Up @@ -839,8 +839,9 @@ fn build_selector(plan: &CreatePlan) -> Result<(serde_json::Value, Option<String
if selector.is_empty() {
return Err(
"nothing to read — pass --table <name> (SQL, Iceberg, DuckLake), --table-path \
<path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an optional --glob \
(buckets), --sql, --raw-sql, --all, or the whole --selector as JSON. A REST \
<path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an \
optional --glob (buckets), --sql, --raw-sql, --all, or the whole --selector as \
JSON. A REST \
source is --selector only: its resources carry endpoints, not just names \
('hotdata ingest sources fields rest')"
Comment on lines 841 to 846

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit: the rewrap leaves JSON. A REST as a short stub line (not blocking). Refilling the remaining continuations keeps the literal readable for the next editor.

Suggested change
"nothing to read — pass --table <name> (SQL, Iceberg, DuckLake), --table-path \
<path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an optional --glob \
(buckets), --sql, --raw-sql, --all, or the whole --selector as JSON. A REST \
<path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an \
optional --glob (buckets), --sql, --raw-sql, --all, or the whole --selector as \
JSON. A REST \
source is --selector only: its resources carry endpoints, not just names \
('hotdata ingest sources fields rest')"
"nothing to read — pass --table <name> (SQL, Iceberg, DuckLake), --table-path \
<path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an \
optional --glob (buckets), --sql, --raw-sql, --all, or the whole --selector as \
JSON. A REST source is --selector only: its resources carry endpoints, not just \
names ('hotdata ingest sources fields rest')"

.into(),
Expand Down
Loading