docs(ingest): name iggy wherever the family lists are spelled - #313
Conversation
The --family help and its error, the --dest-table-prefix doc, and the skill's prefix note listed the families without iggy, so the CLI's own help contradicted the skill. The skill's --stream note also named derived, a family the CLI never exposes. One overlong string line rewrapped.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| /// Common prefix for the destination tables of a source that lands | ||
| /// SEVERAL: SQL --table/--sql, Iceberg, DuckLake, Kafka, REST. Each | ||
| /// source table `orders` lands as `<prefix>_orders`. | ||
| /// SEVERAL: SQL --table/--sql, Iceberg, DuckLake, Kafka, Iggy, REST. |
There was a problem hiding this comment.
nit: one more copy of this same list still omits Iggy (not blocking).
src/client/ingest.rs:167 prints the multi-table family list in the invalid_destination error hint: (SQL --table/--sql, Iceberg, DuckLake, Kafka, REST). That line is outside this diff, so a suggestion block cannot reach it.
A user who passes --dest-table with an Iggy source hits that hint and reads a list that excludes Iggy. The hint then contradicts this --help text and skills/hotdata/SKILL.md:393. Add Iggy after Kafka there for the same reason the other two lists changed.
| "nothing to read — pass --table <name> (SQL, Iceberg, DuckLake), --table-path \ | ||
| <path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an optional --glob \ | ||
| (buckets), --sql, --raw-sql, --all, or the whole --selector as JSON. A REST \ | ||
| <path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an \ | ||
| optional --glob (buckets), --sql, --raw-sql, --all, or the whole --selector as \ | ||
| JSON. A REST \ | ||
| source is --selector only: its resources carry endpoints, not just names \ | ||
| ('hotdata ingest sources fields rest')" |
There was a problem hiding this comment.
super nit: the rewrap leaves JSON. A REST as a short stub line (not blocking). Refilling the remaining continuations keeps the literal readable for the next editor.
| "nothing to read — pass --table <name> (SQL, Iceberg, DuckLake), --table-path \ | |
| <path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an optional --glob \ | |
| (buckets), --sql, --raw-sql, --all, or the whole --selector as JSON. A REST \ | |
| <path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an \ | |
| optional --glob (buckets), --sql, --raw-sql, --all, or the whole --selector as \ | |
| JSON. A REST \ | |
| source is --selector only: its resources carry endpoints, not just names \ | |
| ('hotdata ingest sources fields rest')" | |
| "nothing to read — pass --table <name> (SQL, Iceberg, DuckLake), --table-path \ | |
| <path> (Delta), --topic <name> (Kafka; Iggy as stream/topic), --format with an \ | |
| optional --glob (buckets), --sql, --raw-sql, --all, or the whole --selector as \ | |
| JSON. A REST source is --selector only: its resources carry endpoints, not just \ | |
| names ('hotdata ingest sources fields rest')" |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
1 participant
Follow-up to the four non-blocking notes on #312: iggy added to the --family help (both commands) and its required-error, to the --dest-table-prefix doc, and to the skill's prefix note; derived dropped from the skill's --stream note since the CLI never exposes it; one overlong string line rewrapped. Tests and the skill gate pass.