Skip to content

fix: serialize purgeRequested as lowercase boolean in REST drop_table #3881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edith007 wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

fix: serialize purgeRequested as lowercase boolean in REST drop_table #3881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyiceberg/catalog/rest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,7 +1339,7 @@ def drop_table(self, identifier: str | Identifier, purge_requested: bool = False
self._check_endpoint(Capability.V1_DELETE_TABLE)
response = self._session.delete(
self.url(Endpoints.drop_table, prefixed=True, **self._split_identifier_for_path(identifier)),
params={"purgeRequested": purge_requested},
params={"purgeRequested": "true" if purge_requested else "false"},
)
try:
response.raise_for_status()
Expand Down
15 changes: 15 additions & 0 deletions tests/catalog/test_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2015,6 +2015,21 @@ def test_delete_table_204(rest_mock: Mocker) -> None:
RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).drop_table(("example", "fokko"))


def test_drop_table_serializes_purge_requested_as_lowercase_bool(rest_mock: Mocker) -> None:
rest_mock.delete(
f"{TEST_URI}v1/namespaces/example/tables/fokko",
json={},
status_code=204,
request_headers=TEST_HEADERS,
)
RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).drop_table(("example", "fokko"), purge_requested=True)
assert rest_mock.last_request is not None
assert rest_mock.last_request.qs == {"purgerequested": ["true"]}

RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN).drop_table(("example", "fokko"), purge_requested=False)
assert rest_mock.last_request.qs == {"purgerequested": ["false"]}


def test_delete_table_from_self_identifier_204(
rest_mock: Mocker, example_table_metadata_with_snapshot_v1_rest_json: dict[str, Any]
) -> None:
Expand Down
Loading