fix: serialize purgeRequested as lowercase boolean in REST drop_table - #3881
Open
edith007 wants to merge 1 commit into
Open
fix: serialize purgeRequested as lowercase boolean in REST drop_table#3881edith007 wants to merge 1 commit into
edith007 wants to merge 1 commit into
Conversation
requests stringifies Python True/False as "True"/"False", which breaks OpenAPI boolean query params on strict REST catalogs. Fixes apache#3836
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RestCatalog.drop_table()passed a Pythonboolas a query param.requestsserializesTrue/Falseas"True"/"False", which is invalid for OpenAPItype: booleanquery parameters and causes 400s on strict REST catalogs (e.g. Aliyun OSS Tables).Solution
Serialize explicitly as lowercase
"true"/"false".Test plan
purgeRequested=true|falsepytest tests/catalog/test_rest.py -k "drop_table_serializes_purge or delete_table_204"Fixes #3836