use irrefutable pattern for stack_pin_init - #172
Open
nbdd0121 wants to merge 1 commit into
Open
Conversation
In Rust 1.100.0, `Infallible` will become an alias of `!`. The let binding in `stack_pin_init` will thus become unreachable and produce a "unreachable expression" warning for subsequent match, and thus will fail `-Dwarnings` build. For this macro, all we need to know is that the error type is uninhabited, so replace this with a irrefutable pattern instead. Reported-by: Mohamad Alsadhan <mo@sdhn.cc> Closes: #171 Signed-off-by: Gary Guo <gary@garyguo.net>
nbdd0121
force-pushed
the
stack_pin_init
branch
from
August 28, 2026 15:51
b5f5b55 to
0cae953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The let binding will produce a "unreachable expression" warning with
Infalliblebecoming an alias of!. For this macro, all we need to know is that the error type is uninhabited, so replace this with a irrefutable pattern instead.Alternative to #171