fix build with latest nightly - #171
Closed
mqqz wants to merge 1 commit into
Closed
Conversation
Binding a value of an uninhabited type now makes everything following it
unreachable. In `stack_pin_init!` the `Infallible` annotation is such a
binding, so the `match x {}` after it is reported as unreachable and
`-Dwarnings` turns that into an error.
Annotate the `Result` instead of the error value, which requires the
initializer to be infallible just the same but has nothing following it.
`Infallible` is also printed as `!` in diagnostics now, so bless the two
tests that show it.
Signed-off-by: Mohamad Alsadhan <mo@sdhn.cc>
Member
|
I created #172 as an alternative fix which I think is clearer. |
Contributor
Author
ojeda
pushed a commit
to Rust-for-Linux/linux
that referenced
this pull request
Aug 31, 2026
In Rust 1.100.0, `Infallible` will become an alias of `!`. The let
binding in `stack_pin_init` will thus become unreachable and produce
an "unreachable expression" warning for the subsequent match, and thus
will fail a `-Dwarnings` build. For this macro, all we need to know is
that the error type is uninhabited, so replace this with an irrefutable
pattern instead.
[ The error looks like (dummy reproducer):
error: unreachable expression
--> rust/kernel/sync.rs:177:5
|
177 | pin_init::stack_pin_init!(let num = 42u32);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| |
| unreachable expression
| any code following this expression is unreachable
|
= note: `-D unreachable-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unreachable_code)]`
= note: this error originates in the macro `pin_init::stack_pin_init` (in Nightly builds, run with -Z macro-backtrace for more info)
- Miguel ]
Reported-by: Mohamad Alsadhan <mo@sdhn.cc>
Closes: Rust-for-Linux/pin-init#171
Signed-off-by: Gary Guo <gary@garyguo.net>
Cc: stable@vger.kernel.org # Needed in 7.1.y and later (for 6.12.y and 6.18.y a custom one is needed).
Link: https://patch.msgid.link/20260828155033.2101924-1-gary@kernel.org
[ Reworded for typos. - Miguel ]
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Binding a value of an uninhabited type now makes everything following it unreachable. In
stack_pin_init!theInfallibleannotation is such a binding, so thematch x {}after it is reported as unreachable and-Dwarningsturns that into an error.Annotate the
Resultinstead of the error value, which requires the initializer to be infallible just the same but has nothing following it.Infallibleis also printed as!in diagnostics now, so bless the two tests that show it.