Skip to content

Preserve canonical DOM identity through SameObject getters #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianRappl merged 3 commits into from
Sep 22, 2026
+42 −0
Merged

Preserve canonical DOM identity through SameObject getters #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cac9d8a
Preserve canonical DOM identity through SameObject getters
PrzemyslawKlys Sep 22, 2026
47b8e9d
Document pending SameObject identity fix
PrzemyslawKlys Sep 22, 2026
c4c8f7a
Document DOM identity fix under version 1.1.1
PrzemyslawKlys Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 1.1.1

- Fixed canonical DOM node identity and concrete prototypes through `DomSameObject` getters (#140)

# 1.1.0

Released on Saturday, September 5 2026.
Expand Down
31 changes: 31 additions & 0 deletions src/AngleSharp.Js.Tests/SameObjectIdentityTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
namespace AngleSharp.Js.Tests
{
using AngleSharp.Dom;
using AngleSharp.Scripting;
using Jint;
using NUnit.Framework;
using System.Threading.Tasks;

[TestFixture]
public class SameObjectIdentityTests
{
[Test]
public async Task MutationTargetUsesTheCanonicalNodeAndItsConcretePrototype()
{
using var context = BrowsingContext.New(Configuration.Default.WithJs());
var document = await context.OpenAsync(response => response.Content("<body id=target>test</body>")).ConfigureAwait(false);
IMutationRecord record = null;
var observer = new MutationObserver((records, _) => record = records[0]);
observer.Connect(document.Body, attributes: true);
document.Body.SetAttribute("data-value", "changed");
observer.Disconnect();
Assert.IsNotNull(record);
var engine = context.GetService<JsScriptingService>().GetOrCreateJint(document);
engine.SetValue("observedRecord", record);
engine.Execute("document.body.marker = 'retained'");
Assert.AreEqual("target", engine.Evaluate("observedRecord.target.id").ToString());
Assert.IsTrue(engine.Evaluate("observedRecord.target === document.body").AsBoolean());
Assert.AreEqual("retained", engine.Evaluate("observedRecord.target.marker").ToString());
}
}
}
7 changes: 7 additions & 0 deletions src/AngleSharp.Js/EngineInstance.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,13 @@ public JsValue GetSameObject(Object owner, MethodInfo getter)
return JsValue.Null;
}

// Nodes and windows already have a canonical proxy. Preserve its identity,
// concrete prototype and script-owned properties across SameObject getters.
if (current is INode || current is IWindow)
{
return GetDomNode(current);
}

var cache = _sameObjects.GetValue(owner, _ => new SameObjectCache());
return cache.GetOrUpdate(getter, current, () => CreateInstance(current, getter.ReturnType));
}
Expand Down
Loading