Preserve canonical DOM identity through SameObject getters - #141
Merged
FlorianRappl merged 3 commits intoSep 22, 2026
Merged
Conversation
FlorianRappl
left a comment
Contributor
There was a problem hiding this comment.
LGTM - we just need to put it into a 1.1.1 version
FlorianRappl
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MutationRecord.targetcurrently gets a new proxy projected asINode, losing the element API and the canonical wrapper used elsewhere. ReuseGetDomNodefor node/window values returned byDomSameObjectgetters so the concrete prototype, strict identity and script-owned properties are preserved. Other SameObject values retain the existing cache.Fixes #140.
The regression exposes an attribute mutation record to Jint and checks
target.id,target === document.body, and an expando written throughdocument.body. It fails on unmodifieddeveland passes with this fix.This reusable binding defect was encountered by the public OfficeIMO HTML runtime. The patch has no OfficeIMO dependency and requires no downstream change or coordinated release to test.
Prerequisites
Contribution type
netstandard2.0build also passed with zero warnings/errors. Local validation used macOS arm64, SDK 10.0.303, AngleSharp 1.8.0 and Jint 4.15.3. Windows/Linux validation is left to the repository CI.