Add the 'cookieSecure' parameter to enable 'CookieLogin' to set a cookie when an HTTP request is made - #139
Open
klsoft-web wants to merge 2 commits into
Open
klsoft-web wants to merge 2 commits into
klsoft-web wants to merge 2 commits into
Conversation
…kie when an HTTP request is made
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #139 +/- ##
=========================================
Coverage 99.67% 99.68%
Complexity 122 122
=========================================
Files 15 15
Lines 311 313 +2
=========================================
+ Hits 310 312 +2
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
samdark
reviewed
Sep 15, 2026
samdark
reviewed
Sep 17, 2026
| - Enh #127: Bump `yiisoft/auth` version to `^3.3.0`, and fix deprecated classes usage (@klsoft-web, @vjik) | ||
| - Enh #132: Bump `yiisoft/session` version to `^3.0.2` (@vjik) | ||
| - New #126: Add optional HMAC signing of the auto-login cookie value via `CookieLogin` signature key (@vjik) | ||
| - Bug #135: Add the `secureCookie` parameter to enable `CookieLogin` to set a cookie when an HTTP request is made (@klsoft-web) |
Member
There was a problem hiding this comment.
Suggested change
| - Bug #135: Add the `secureCookie` parameter to enable `CookieLogin` to set a cookie when an HTTP request is made (@klsoft-web) | |
| - Enh #135: Add the `secureCookie` parameter to enable `CookieLogin` to set a cookie when an HTTP request is made (@klsoft-web) |
samdark
requested changes
Sep 17, 2026
| ``` | ||
|
|
||
| > If you want the cookie to be a session cookie, change the duration to `null`. | ||
| > To enable a cookie to be set when an HTTP request is made, change the `secureCookie` to `false`. |
Member
There was a problem hiding this comment.
I think we need to warn about consequences here. Something like:
With
secureCookieturned off, it travels in cleartext and can be captured and replayed for the full duration of cookie lifetime (5 days by default).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the 'cookieSecure' parameter to enable 'CookieLogin' to set a cookie when an HTTP request is made