Fenrir fixes - #11299
Conversation
Both server side (don't send) and client side (alert). This is disallowed by RFC 9001 §4.4.
There was a problem hiding this comment.
Pull request overview
Fixes Fenrir issues related to QUIC + TLS 1.3 post-handshake authentication behavior and improves robustness of the MAX3266x MAA hardware math path.
Changes:
- Initialize the temporary
mp_intresult struct in the MAX3266x MAA hardware math helper when the output aliases an input. - Disallow TLS 1.3 post-handshake authentication APIs when the
WOLFSSL*is configured for QUIC, and reject QUIC post-handshakeCertificateRequestmessages. - Add a QUIC regression check asserting post-handshake auth APIs fail under QUIC (per RFC 9001 §4.4).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| wolfcrypt/src/port/maxim/max3266x.c | Zero-initializes a temporary mp_int used as a non-aliased hardware result buffer. |
| tests/quic.c | Adds test coverage ensuring post-handshake auth APIs are rejected for QUIC connections. |
| src/tls13.c | Enforces “no post-handshake auth over QUIC” in both message handling and public APIs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Can one of the admins verify this patch? |
|
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11299
Scan targets checked: wolfcrypt-port-bugs, wolfssl-bugs, wolfssl-src
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
|
Jenkins retest this please |
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11299
Scan targets checked: wolfcrypt-port-bugs, wolfssl-src, wolfssl-bugs
Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Reviewed bot's comments
Description
Fixes F-10044, F-10725, F-10726