Skip to content

Fenrir fixes - #11299

Merged
JacobBarthelmeh merged 5 commits into
wolfSSL:masterfrom
mattia-moffa:20260826-fenrir-fixes
Sep 9, 2026
Merged

Fenrir fixes#11299
JacobBarthelmeh merged 5 commits into
wolfSSL:masterfrom
mattia-moffa:20260826-fenrir-fixes

Conversation

@mattia-moffa

@mattia-moffa mattia-moffa commented Aug 27, 2026

Copy link
Copy Markdown
Member

Description

Fixes F-10044, F-10725, F-10726

  • F-10044: MAX3266X-specific reliability bug
  • F-10725, F-10726: protocol compliance bug

Both server side (don't send) and client side (alert). This is
disallowed by RFC 9001 §4.4.
@mattia-moffa mattia-moffa self-assigned this Aug 27, 2026
Copilot AI lite review requested due to automatic review settings August 27, 2026 03:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Fenrir issues related to QUIC + TLS 1.3 post-handshake authentication behavior and improves robustness of the MAX3266x MAA hardware math path.

Changes:

  • Initialize the temporary mp_int result struct in the MAX3266x MAA hardware math helper when the output aliases an input.
  • Disallow TLS 1.3 post-handshake authentication APIs when the WOLFSSL* is configured for QUIC, and reject QUIC post-handshake CertificateRequest messages.
  • Add a QUIC regression check asserting post-handshake auth APIs fail under QUIC (per RFC 9001 §4.4).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
wolfcrypt/src/port/maxim/max3266x.c Zero-initializes a temporary mp_int used as a non-aliased hardware result buffer.
tests/quic.c Adds test coverage ensuring post-handshake auth APIs are rejected for QUIC connections.
src/tls13.c Enforces “no post-handshake auth over QUIC” in both message handling and public APIs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/tls13.c
@wolfSSL-Bot

Copy link
Copy Markdown

Can one of the admins verify this patch?

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

gcc-arm-cortex-m4

  • FLASH: .rodata.CSWTCH.1 +16 B, .rodata.str1.1 +158 B, .text +192 B (+0.2%, 204,701 B / 262,144 B, total: 78% used)

gcc-arm-cortex-m4-crypto-only

  • FLASH: .rodata.CSWTCH.1 +16 B, .rodata.str1.1 +158 B, .text +192 B (+0.2%, 178,328 B / 262,144 B, total: 68% used)

gcc-arm-cortex-m4-dtls13

  • FLASH: .text +192 B (+0.1%, 186,428 B / 1,048,576 B, total: 18% used)

gcc-arm-cortex-m4-openssl-compat

  • FLASH: .rodata +176 B, .text +192 B (+0.0%, 780,652 B / 1,048,576 B, total: 74% used)

gcc-arm-cortex-m4-pkcs7

  • FLASH: .rodata.CSWTCH.1 +16 B, .rodata.str1.1 +158 B, .text +128 B (+0.1%, 217,564 B / 262,144 B, total: 83% used)

gcc-arm-cortex-m4-pq

  • FLASH: .rodata +168 B, .text +192 B (+0.1%, 301,380 B / 1,048,576 B, total: 29% used)

gcc-arm-cortex-m4-rsa-only

  • FLASH: .rodata +176 B, .text +64 B (+0.1%, 331,680 B / 1,048,576 B, total: 32% used)

gcc-arm-cortex-m4-tls13

  • FLASH: .rodata.CSWTCH.1 +16 B, .rodata.str1.1 +158 B, .text +192 B (+0.2%, 241,999 B / 262,144 B, total: 92% used)

gcc-arm-cortex-m7

  • FLASH: .rodata.CSWTCH.1 +16 B, .rodata.str1.1 +158 B, .text +192 B (+0.2%, 204,701 B / 262,144 B, total: 78% used)

gcc-arm-cortex-m7-pq

  • FLASH: .rodata +168 B, .text +192 B (+0.1%, 302,340 B / 1,048,576 B, total: 29% used)

gcc-arm-cortex-m7-tls13

  • FLASH: .rodata.CSWTCH.1 +16 B, .rodata.str1.1 +158 B, .text +192 B (+0.2%, 242,063 B / 262,144 B, total: 92% used)

linuxkm-pie

  • Data: __patchable_function_entries +88 B (+0.3%, 26,936 B)

linuxkm-standard

  • Data: __patchable_function_entries +80 B (+0.2%, 49,744 B)

stm32-sim-stm32h753

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #11299

Scan targets checked: wolfcrypt-port-bugs, wolfssl-bugs, wolfssl-src

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

@mattia-moffa

Copy link
Copy Markdown
Member Author

Jenkins retest this please

@mattia-moffa mattia-moffa removed their assignment Sep 9, 2026
@mattia-moffa mattia-moffa added the For This Release Release version 5.9.4 label Sep 9, 2026
@JacobBarthelmeh
JacobBarthelmeh requested review from wolfSSL-Fenrir-bot and removed request for wolfSSL-Fenrir-bot September 9, 2026 19:36

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #11299

Scan targets checked: wolfcrypt-port-bugs, wolfssl-src, wolfssl-bugs

Findings: 2
2 finding(s) posted as inline comments (see file-level comments below)

This review was generated automatically by Fenrir. Reported findings require changes before merge.

Comment thread src/tls13.c
Comment thread tests/quic.c
@JacobBarthelmeh
JacobBarthelmeh merged commit 2a78241 into wolfSSL:master Sep 9, 2026
386 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants