SP ARM64 generation: fixed and output improved - #11298
Merged
Merged
Conversation
Contributor
Author
|
Code generated by PR: |
|
Can one of the admins verify this patch? |
Contributor
Author
|
Jenkins: retest this please |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11298
No scan targets match the changed files in this PR. Review skipped.
Code generation was fixed to no longer write out functions and assembly instructions with puts. Some fixes have been made as a result that don't affect performance.
SparkiDev
force-pushed
the
sp_arm64_gen
branch
from
August 27, 2026 06:30
c29ba59 to
497d0a7
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11298
No scan targets match the changed files in this PR. Review skipped.
Contributor
|
Tests good with enable-all-crypto enable-all-quantum-crypto enable-sp enable-sp-asm + sanitizer + qemu-aarch64-static with benchmark and testwolfcrypt. |
philljj
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Code generation was fixed to no longer write out functions and assembly instructions with puts.
Some fixes have been made as a result that don't affect performance.
Testing
Regression tested SP on ARM64.