fwd: drop the declarations with no definition - #1210
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR cleans up the public forwarding API surface in wolfssh/ssh.h by removing two exported function declarations that have no implementation (and therefore can only produce link errors), and by clarifying that the WS_CallbackFwdIO callback parameter is currently stored but never invoked by the library.
Changes:
- Removed the public declarations of
wolfSSH_CTX_SetFwdEnable()andwolfSSH_SetFwdEnable()fromwolfssh/ssh.h(both were declared but not defined anywhere). - Added a header comment documenting that
WS_CallbackFwdIOis reserved:wolfSSH_CTX_SetFwdCb()stores it, but forwarding I/O flows through the channel API rather than this callback.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ejohnstown
requested review from
wolfSSL-Fenrir-bot
and removed request for
wolfSSL-Fenrir-bot
August 28, 2026 17:38
wolfSSH_CTX_SetFwdEnable() and wolfSSH_SetFwdEnable() are declared in ssh.h and defined nowhere, so calling either is a link error rather than a way to gate forwarding. Nothing can depend on them today. - delete both declarations - say in the header that the WS_CallbackFwdIO passed to wolfSSH_CTX_SetFwdCb() is stored and never called; the parameter stays so existing calls still compile The third dead corner, the WOLFSSH_FWD_LOCAL_CLEANUP action the library never emits, needs a setup/cleanup pairing record and a callback that names the channel. That work is parked on ccb-phase2-local-cleanup.
ejohnstown
force-pushed
the
ccb-phase1-6
branch
from
August 28, 2026 19:44
04a35e2 to
9e49f4c
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1210
Scan targets checked: wolfssh-bugs, wolfssh-src
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
philljj
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfSSH_CTX_SetFwdEnable()andwolfSSH_SetFwdEnable()are declared inssh.hand defined nowhere, so calling either is a link error ratherthan a way to gate forwarding. Nothing can depend on them today.
WS_CallbackFwdIOpassed towolfSSH_CTX_SetFwdCb()is stored and never called; the parameterstays so existing calls still compile
The third dead corner, the
WOLFSSH_FWD_LOCAL_CLEANUPaction the librarynever emits, needs a setup/cleanup pairing record and a callback that
names the channel. That is larger than a cleanup and is not in this PR.