examples, tests: terminate the ES_ERROR messages with a newline - #1208
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the readability of error output produced by the ES_ERROR() macro by ensuring affected messages end with a trailing newline, preventing stderr output from running into subsequent shell/test-harness text.
Changes:
- Add
\nterminators toES_ERROR()format strings intests/auth.c. - Add
\nterminators toES_ERROR()format strings in the main echoserver example. - Apply the same newline termination fix to the Espressif ESP-IDF echoserver example copy.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/auth.c | Ensures ES_ERROR() stderr messages in auth test server thread are newline-terminated. |
| examples/echoserver/echoserver.c | Ensures selected echoserver ES_ERROR() messages are newline-terminated. |
| ide/Espressif/ESP-IDF/examples/wolfssh_echoserver/main/echoserver.c | Mirrors the newline-termination fix in the ESP-IDF echoserver copy. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ES_ERROR() passes its arguments straight to fprintf(stderr, ...), so a message with no trailing newline runs into whatever the shell or the test harness prints next. - 7 sites in the echoserver, 6 in tests/auth.c, 8 in the Espressif copy of the echoserver, which carries the same macro and takes this kind of cross-cutting fix (e91ff50, ab8058d) - the two wrapped format strings already ended with a newline
ejohnstown
force-pushed
the
ccb-phase1-4
branch
from
August 28, 2026 19:43
4b20f1a to
393b385
Compare
ejohnstown
requested review from
wolfSSL-Fenrir-bot
and removed request for
wolfSSL-Fenrir-bot
August 28, 2026 19:44
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1208
Scan targets checked: wolfssh-bugs, wolfssh-src
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
philljj
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ES_ERROR()passes its arguments straight tofprintf(stderr, ...), soa message with no trailing newline runs into whatever the shell or the
test harness prints next.
tests/auth.c, 8 in the Espressif copyof the echoserver, which carries the same macro and takes this kind of
cross-cutting fix (e91ff50, ab8058d)
Message text only; no logic change.