Add ToolActivatedEvent and ToolCancelEvent interfaces - #245
Merged
Merged
Conversation
beaufortfrancois
force-pushed
the
events
branch
from
August 19, 2026 09:20
23ec0f3 to
dd8d5cb
Compare
beaufortfrancois
force-pushed
the
events
branch
6 times, most recently
from
August 20, 2026 07:26
47ba6f5 to
d74f4e0
Compare
beaufortfrancois
force-pushed
the
events
branch
from
August 20, 2026 07:37
d74f4e0 to
3e0df08
Compare
markafoltz
self-requested a review
September 16, 2026 21:24
markafoltz
approved these changes
Sep 16, 2026
Collaborator
|
This PR LGTM, but there's still the issue of how to expose the state of concurrent / re-entrant tool executions. So it will be premature to merge if we think the event shape will change in response. |
domfarolino
approved these changes
Sep 17, 2026
domfarolino
left a comment
domfarolino
left a comment
Collaborator
There was a problem hiding this comment.
This PR LGTM, but there's still the issue of how to expose the state of concurrent / re-entrant tool executions.
I like to think that we won't want to expose something like this directly, but instead let developers keep track of that bookkeeping themselves. I think of it like event handlers; they can happen concurrently and re-entrantly, but we don't put the browser in charge of tracking that. I imagine we'll mirror that approach with WebMCP tool calls, but we'll see if that plays nicely with developers.
github-actions Bot
added a commit
that referenced
this pull request
Sep 17, 2026
SHA: f5645e9 Reason: push, by domfarolino Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #126 (comment), this PR supersedes #146 and adds new
ToolActivatedEventandToolCancelEventinterfaces.Preview | Diff