Reject mismatched vector names in multi-target searches - #2161
Merged
Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Contributor
Author
|
I agree to the CLA |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The validation is consistent across affected request paths and has focused version-specific coverage.
Pull request overview
Adds validation to reject mismatched vector dictionary keys and requested target vectors.
Changes:
- Validates target names across legacy and modern request encodings.
- Adds regression coverage for near-vector and hybrid searches.
File summaries
| File | Description |
|---|---|
weaviate/collections/grpc/shared.py |
Enforces matching vector and target names. |
test/collection/test_target_vectors.py |
Tests mismatches, ordering, and repeated weighted targets. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Reject vector dictionaries whose keys differ from the requested target vector names before constructing a near-vector or hybrid request.
For example,
near_vector={"body": [1.0, 0.0]}withtarget_vector=["title"]currently changes the request target tobodyon Weaviate 1.27+ instead of reporting the mismatch. UsingTargetVectors.manual_weights({"title": 1.0})instead raisesKeyError. The legacy request path also accepts mismatched names.These inputs now raise
WeaviateInvalidInputError. Matching names may still appear in a different order, and repeated targets with multiple weights remain supported.Validation
HybridVector.near_vectorrequest construction across the legacy, 1.27, and 1.29 encodings.pytest test mock_tests -q: 539 passed, 1 skipped.weaviatereported 0 errors and 0 warnings.AI assistance: Codex helped investigate, implement, test, and review this change.