[HTTPXodus] migrate httpx to httpx2 (hard switch; closes #2154) - #2155
Open
ProgrammerPlus1998 wants to merge 3 commits into
Open
ProgrammerPlus1998 wants to merge 3 commits into
ProgrammerPlus1998 wants to merge 3 commits into
Conversation
Use the actively maintained httpx2 fork (Pydantic Services) when available, falling back to httpx. setup.cfg updated; 22 source files migrated with try/except dual-import. Public API unchanged. Refs: weaviate#2154
ProgrammerPlus1998
force-pushed
the
httpxodus/httpx2-migration
branch
from
September 4, 2026 07:10
a5cde23 to
d496df2
Compare
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I agree to the Weaviate Contributor License Agreement (CLA). Thanks! |
Remove all try/except ImportError dual-import blocks (21 modules); direct httpx2 imports everywhere. setup.cfg: drop httpx, httpx2>=2.12.0 unconditional (python_requires is already >=3.10). Refs: weaviate#2154
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2154
What this PR does
Complete hard switch from
httpxtohttpx2:try/except ImportErrordual-import blocks — directhttpx2imports everywhere (connect/v4.py,util.py,embedded.py,exceptions.py,client_executor.py, etc.)setup.cfg: dropshttpx>=0.26.0,<0.29.0;httpx2>=2.12.0unconditional (python_requiresis already>=3.10, matching httpx2's floor)Test results
test/, excludingtest/collectionwhich needs a live server): 91 passed with httpx2 2.12.0 in an isolated envNotes for reviewer
httpx2verifies TLS against the OS trust store (viatruststore) instead of the bundledcertifi. Deployments that relied on certifi's CA bundle (minimal containers, corporate proxies) may needSSL_CERT_FILE/SSL_CERT_DIRafter the switch. Worth a line in the changelog.Happy to revise per review — and equally happy to close this PR if the maintainers would rather wait for
httpx1.0 stable. 🙏