Skip to content

refactor(array): allocate execution outputs through context - #9671

Draft
gatesn wants to merge 1 commit into
ngates/buffer-allocator-buildersfrom
ngates/buffer-allocator-execution
Draft

refactor(array): allocate execution outputs through context#9671
gatesn wants to merge 1 commit into
ngates/buffer-allocator-buildersfrom
ngates/buffer-allocator-execution

Conversation

@gatesn

@gatesn gatesn commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Allocate execution outputs through the execution context.

Changes

  • Propagate allocators through filter, take, interleave, and patches.
  • Use context allocators in dictionary and scalar functions.
  • Add tests for allocator propagation.

@codspeed-hq

codspeed-hq Bot commented Aug 27, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 20.58%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 3 regressed benchmarks
✅ 66 untouched benchmarks
🆕 6 new benchmarks
⏩ 2176 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime mul_u64_nonnull_neon 15.2 µs 20.2 µs -24.7%
WallTime multiply_shapes_neon[(16384, PerRowPerRow)] 17.2 µs 21.1 µs -18.77%
WallTime mul_i64_nonnull_neon 17.1 µs 20.9 µs -18.1%
🆕 WallTime deferred_bool_neon[i32, ConstantPerRow] N/A 4.5 µs N/A
🆕 WallTime deferred_bool_neon[i32, PerRowConstant] N/A 5.3 µs N/A
🆕 WallTime deferred_bool_neon[i32, PerRowPerRow] N/A 4.4 µs N/A
🆕 WallTime deferred_bool_neon[i64, ConstantPerRow] N/A 5.9 µs N/A
🆕 WallTime deferred_bool_neon[i64, PerRowConstant] N/A 7.2 µs N/A
🆕 WallTime deferred_bool_neon[i64, PerRowPerRow] N/A 6.9 µs N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/buffer-allocator-execution (3c868b7) with develop (ba90f3d)2

Open in CodSpeed

Footnotes

  1. 2176 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on ngates/buffer-allocator-builders (fd018db) during the generation of this report, so develop (ba90f3d) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@gatesn gatesn mentioned this pull request Aug 27, 2026
5 tasks
@gatesn
gatesn force-pushed the ngates/buffer-allocator-execution branch from f8000e4 to 9a8b653 Compare August 27, 2026 19:38
@gatesn
gatesn force-pushed the ngates/buffer-allocator-execution branch 2 times, most recently from 6931802 to ed2fbe7 Compare August 27, 2026 21:37
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn
gatesn force-pushed the ngates/buffer-allocator-execution branch from ed2fbe7 to 3c868b7 Compare August 27, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant