Skip to content

fix: validate buffer slice alignment - #9659

Open
0ax1 wants to merge 3 commits into
developfrom
ad/validate-buffer-slice-alignment
Open

fix: validate buffer slice alignment#9659
0ax1 wants to merge 3 commits into
developfrom
ad/validate-buffer-slice-alignment

Conversation

@0ax1

@0ax1 0ax1 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Prevent slices from reporting an alignment stronger than their source buffer and cover preferred-versus-required alignment propagation.

Prevent slices from reporting an alignment stronger than their source buffer and cover preferred-versus-required alignment propagation.

Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@0ax1
0ax1 requested a review from joseph-isaacs August 27, 2026 11:18
@0ax1
0ax1 enabled auto-merge (squash) August 27, 2026 11:18
@0ax1 0ax1 added the changelog/fix A bug fix label Aug 27, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 27, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 7.98%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 2 improved benchmarks
❌ 4 regressed benchmarks
✅ 2124 untouched benchmarks
⏩ 106 skipped benchmarks1
🗄️ 4 archived benchmarks run2

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime arrow_checked_add_u32_neon[16384] 13.5 µs 20.3 µs -33.68%
WallTime multiply_shapes_neon[(128, ConstantPerRow)] 3.1 µs 3.8 µs -16.67%
WallTime add_shapes_neon[(128, PerRowConstant)] 3 µs 3.5 µs -15.18%
WallTime subtract_shapes_neon[(128, PerRowNullableConstant)] 3.7 µs 4.1 µs -10.71%
WallTime arrow_checked_add_u32_avx2[16384] 21.3 µs 17.7 µs +20.46%
WallTime arrow_checked_add_u32_avx512[16384] 21.2 µs 17.6 µs +20.43%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ad/validate-buffer-slice-alignment (66a433a) with develop (59a056d)

Open in CodSpeed

Footnotes

  1. 106 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. 4 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

Comment thread vortex-buffer/src/buffer.rs Outdated
Co-authored-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Comment thread vortex-buffer/src/buffer.rs Outdated
@0ax1 0ax1 closed this Aug 27, 2026
auto-merge was automatically disabled August 27, 2026 13:05

Pull request was closed

@0ax1 0ax1 reopened this Aug 27, 2026
Co-authored-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
@robert3005

Copy link
Copy Markdown
Contributor

one of the tests you added here is still failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants