Skip to content

Fix Fastly domain reassignment renewal check - #10

Merged
loks0n merged 2 commits into
mainfrom
codex/fastly-domain-renewal
Aug 28, 2026
Merged

loks0n merged 2 commits into
mainfrom
codex/fastly-domain-renewal

Conversation

@loks0n

@loks0n loks0n commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • require certificate issuance when a Fastly domain is missing or belongs to another service
  • delegate to TLS renewal checks once the domain is already assigned correctly
  • cover both ownership paths

Tests

  • vendor/bin/phpunit tests/Cdn/Certificates/Provider/FastlyTest.php
  • vendor/bin/pint --test src/Cdn/Certificates/Provider/Fastly.php tests/Cdn/Certificates/Provider/FastlyTest.php
  • vendor/bin/phpstan analyse -c phpstan.neon --memory-limit=2G src/Cdn/Certificates/Provider/Fastly.php

@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown

Greptile Summary

The PR aligns Fastly renewal checks with domain ownership before delegating correctly assigned domains to TLS renewal logic.

  • Requires issuance when a domain is absent or assigned to another Fastly service.
  • Skips unsupported renewal work for classic domains without a service assignment.
  • Adds focused coverage for missing ownership, foreign ownership, and current-service delegation.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported classic-domain renewal loop is fixed by returning false for records without a service assignment.

Important Files Changed

Filename Overview
src/Cdn/Certificates/Provider/Fastly.php Adds ownership-aware renewal decisions and resolves the previously reported perpetual renewal signal for classic domains.
tests/Cdn/Certificates/Provider/FastlyTest.php Covers foreign-service ownership, classic domains, and delegation to TLS renewal checks for correctly assigned domains.

Reviews (2): Last reviewed commit: "Skip renewal for classic Fastly domains" | Re-trigger Greptile

Comment thread src/Cdn/Certificates/Provider/Fastly.php Outdated
@loks0n
loks0n merged commit e7fb311 into main Aug 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant