Fix Fastly domain reassignment renewal check - #10
Merged
Merged
Conversation
Greptile SummaryThe PR aligns Fastly renewal checks with domain ownership before delegating correctly assigned domains to TLS renewal logic.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported classic-domain renewal loop is fixed by returning false for records without a service assignment. Important Files Changed
Reviews (2): Last reviewed commit: "Skip renewal for classic Fastly domains" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
vendor/bin/phpunit tests/Cdn/Certificates/Provider/FastlyTest.phpvendor/bin/pint --test src/Cdn/Certificates/Provider/Fastly.php tests/Cdn/Certificates/Provider/FastlyTest.phpvendor/bin/phpstan analyse -c phpstan.neon --memory-limit=2G src/Cdn/Certificates/Provider/Fastly.php