Skip to content

VPR-188 feat(deploy): set the Hangfire shutdown timeout chain explicitly - #344

Draft
rlorenzo wants to merge 1 commit into
feature/VPR-187-data-protection-key-ringfrom
feature/VPR-188-hangfire-shutdown-chain
Draft

rlorenzo wants to merge 1 commit into
feature/VPR-187-data-protection-key-ringfrom
feature/VPR-188-hangfire-shutdown-chain

Conversation

@rlorenzo

Copy link
Copy Markdown
Contributor
  • Hangfire 15s <= host 30s <= IIS shutdownTimeLimit 90s, matching the
    defaults that were previously implicit
  • A slot flip stops a pool mid-drain, so each link must leave the next
    room to finish a job rather than cut it off and re-queue it
  • The IIS link is app pool config and ships with the two-slot layout

Stack created with GitHub Stacks CLIGive Feedback 💬

@rlorenzo
rlorenzo added this pull request to stack #345 September 17, 2026 07:29
@codecov-commenter

codecov-commenter commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.37%. Comparing base (6ab4555) to head (eb54f77).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
web/Classes/Scheduler/HangfireExtensions.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                             Coverage Diff                              @@
##           feature/VPR-187-data-protection-key-ring     #344      +/-   ##
============================================================================
- Coverage                                     45.38%   45.37%   -0.01%     
============================================================================
  Files                                           949      949              
  Lines                                         49546    49547       +1     
  Branches                                       6702     6703       +1     
============================================================================
  Hits                                          22484    22484              
- Misses                                        26095    26096       +1     
  Partials                                        967      967              
Flag Coverage Δ
backend 42.34% <0.00%> (-0.01%) ⬇️
frontend 64.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
web/Classes/Scheduler/HangfireExtensions.cs 0.00% <0.00%> (ø)

@rlorenzo
rlorenzo force-pushed the feature/VPR-188-hangfire-shutdown-chain branch from 3f1ec7b to c6b7459 Compare September 17, 2026 14:21
@codecov-commenter

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@rlorenzo
rlorenzo force-pushed the feature/VPR-188-hangfire-shutdown-chain branch 2 times, most recently from bc71106 to 7ddb5f5 Compare September 17, 2026 14:50
- Hangfire 15s <= host 30s <= IIS shutdownTimeLimit 90s, matching the
  defaults that were previously implicit
- A slot flip stops a pool mid-drain, so each link must leave the next
  room to finish a job rather than cut it off and re-queue it
- The IIS link is app pool config and ships with the two-slot layout
@rlorenzo
rlorenzo force-pushed the feature/VPR-188-hangfire-shutdown-chain branch from 7ddb5f5 to eb54f77 Compare September 22, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants