[2/2 messagequeue] Add Vitess vschema and two-shard vtcombo suite - #696
Merged
Conversation
This was referenced Sep 8, 2026
behinddwalls
force-pushed
the
preetam/mq-tenant-vitess
branch
from
September 8, 2026 06:03
c9519fb to
10f0140
Compare
behinddwalls
force-pushed
the
preetam/mq-tenant-vitess
branch
from
September 8, 2026 06:06
10f0140 to
0b69e19
Compare
behinddwalls
marked this pull request as ready for review
September 10, 2026 16:30
mnoah1
approved these changes
Sep 10, 2026
behinddwalls
force-pushed
the
preetam/mq-tenant-vitess
branch
from
September 10, 2026 18:57
0b69e19 to
4980b66
Compare
behinddwalls
changed the title
behinddwalls
added a commit
that referenced
this pull request
Sep 10, 2026
## Summary ### Why? Vitess needs a stable vindex that is not the Kafka-style partition key. Isolation has to be an explicit tenant column, with identity carried on publish and consume so two tenants sharing a partition key cannot collide. ### What? - Prefix every queue table and store query with tenant; set queue_offsets PK to (tenant, topic, partition_key, consumer_group). - Use typed (tenant, partitionKey) identities in consumers, gates, and MySQL workers; stop workers when lease discovery cannot confirm ownership. - Require tenant on publish.Message and validate payload queue against message tenant in pipeline controllers (the publish signature change is not compilable without those call sites). - Add ParseRequiredTenants and wire Stovepipe ingest to the configured tenant list so NewIngestController still builds. - Require tenant xor all-tenants on MQ admin list commands; message inspect/delete/requeue take the full (tenant, topic, partition, id) identity. - Comment ascii/ascii_bin vs utf8mb4/utf8mb4_bin on every queue table, with the full encoding note on queue_messages. ## Test Plan ✅ `go test` on mysql, publish, consumer, messagequeue identity, service/messagequeue, and start controller Rebased onto current `main` after RFC #693 merged. ## Stack - ~~[#693](#693) RFC: per-tenant sharding for the MySQL message queue~~ (merged) - [#694](#694) Shard MySQL queues by tenant identity - [#695](#695) Wire MQ_TENANTS through services and tests - [#696](#696) Add Vitess vschema and two-shard vtcombo suite --------- Co-authored-by: Cursor <cursoragent@cursor.com>
behinddwalls
force-pushed
the
preetam/mq-tenant-vitess
branch
from
September 10, 2026 19:51
4980b66 to
59b20cb
Compare
behinddwalls
changed the title
behinddwalls
added a commit
that referenced
this pull request
Sep 10, 2026
## Summary ### Why? The MySQL subscriber only discovers partitions for configured tenants. Service processes and compose stacks must pass the same list they already use as queue names, or Subscribe fails at startup and tests talk to an unsharded process. ### What? - Parse MQ_TENANTS in gateway, orchestrator, and runway wiring and reject configs whose queue names do not match. - Set MQ_TENANTS in service compose files, e2e harnesses, and SubmitQueue integration suites. ## Test Plan ✅ `go test` TestValidateConfiguredQueueTenants, TestValidateProfileQueueTenants, TestValidateMergeQueueTenants, and service/messagequeue Rebased onto current `main` after #694 merged. ## Stack - ~~[#693](#693) RFC: per-tenant sharding for the MySQL message queue~~ (merged) - ~~[#694](#694) Shard MySQL queues by tenant identity~~ (merged) - [#695](#695) Wire MQ_TENANTS through services and tests - [#696](#696) Add Vitess vschema and two-shard vtcombo suite Co-authored-by: Cursor <cursoragent@cursor.com>
behinddwalls
added a commit
that referenced
this pull request
Sep 10, 2026
## Summary ### Why? The MySQL subscriber only discovers partitions for configured tenants. Service processes and compose stacks must pass the same list they already use as queue names, or Subscribe fails at startup and tests talk to an unsharded process. ### What? - Parse MQ_TENANTS in gateway, orchestrator, and runway wiring and reject configs whose queue names do not match. - Set MQ_TENANTS in service compose files, e2e harnesses, and SubmitQueue integration suites. ## Test Plan ✅ `go test` TestValidateConfiguredQueueTenants, TestValidateProfileQueueTenants, TestValidateMergeQueueTenants, and service/messagequeue Rebased onto current `main` after #694 merged. ## Stack - ~~[#693](#693) RFC: per-tenant sharding for the MySQL message queue~~ (merged) - ~~[#694](#694) Shard MySQL queues by tenant identity~~ (merged) - [#695](#695) Wire MQ_TENANTS through services and tests - [#696](#696) Add Vitess vschema and two-shard vtcombo suite Co-authored-by: Cursor <cursoragent@cursor.com>
behinddwalls
force-pushed
the
preetam/mq-tenant-vitess
branch
from
September 10, 2026 19:59
59b20cb to
13addff
Compare
## Summary ### Why? The tenant column is the production vindex. Without a VSchema and a two-shard suite, the schema change is unproven on Vitess. ### What? - Add production xxhash VSchema for every queue table keyed on tenant. - Add a vtcombo integration suite that publishes and consumes across two shards (receive loop bound to the test context). Admin CLI tenant flags shipped with the schema PR because ctl/lib SQL is coupled to the new primary keys. ## Test Plan Vitess suite is Docker-based; run with: `./tool/bazel test //test/integration/extension/messagequeue/mysql/vitess:go_default_test --strategy=TestRunner=local` Co-authored-by: Cursor <cursoragent@cursor.com>
behinddwalls
force-pushed
the
preetam/mq-tenant-vitess
branch
from
September 10, 2026 20:08
13addff to
a225fd4
Compare
behinddwalls
changed the title
behinddwalls
changed the title
behinddwalls
force-pushed
the
preetam/mq-tenant-vitess
branch
from
September 10, 2026 21:00
ab68ac3 to
a225fd4
Compare
behinddwalls
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
The tenant column is the production vindex. Without a VSchema and a two-shard suite, the schema change is unproven on Vitess.
What?
Admin CLI tenant flags shipped with the schema PR because ctl/lib SQL is coupled to the new primary keys.
Test Plan
Vitess suite is Docker-based; run with:
./tool/bazel test //test/integration/extension/messagequeue/mysql/vitess:go_default_test --strategy=TestRunner=localCo-authored-by: Cursor cursoragent@cursor.com