refactor: separate land workflow from runway merge - #689
Open
behinddwalls wants to merge 1 commit into
Open
Conversation
behinddwalls
marked this pull request as ready for review
September 8, 2026 03:52
behinddwalls
force-pushed
the
preetam/land-terminology-core
branch
from
September 8, 2026 05:21
efec5d1 to
2637121
Compare
This was referenced Sep 8, 2026
## Summary ### Why? SubmitQueue owns the user-facing land workflow, while Runway owns the merge execution contract. Keeping those terms distinct makes the service boundary explicit without renaming Runway's published contract. ### What? Rename SubmitQueue lifecycle states, controllers, internal topics, and their tests to land terminology. Preserve Runway `MergeRequest`, `MergeStep`, `MergeResult`, merge controllers, extensions, configuration, and merge topic names, with translation at the validation, land-dispatch, and result-signal boundaries. Preserve every merge strategy mapping, including `PROMOTE`. ## Test Plan - ✅ `make gazelle` - ✅ `make test`
behinddwalls
force-pushed
the
preetam/land-terminology-core
branch
from
September 10, 2026 16:35
2637121 to
ed06d7c
Compare
sbalabanov
approved these changes
Sep 10, 2026
| @@ -1 +1 @@ | |||
| // Copyright (c) 2025 Uber Technologies, Inc. | |||
Contributor
There was a problem hiding this comment.
Everything in this file is git-related, should it be "merge" and not "land"?
There is no "land" in git terms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
SubmitQueue owns the user-facing land workflow, while Runway owns the merge execution contract. Keeping those terms distinct makes the service boundary explicit without renaming Runway's published contract.
What?
Rename SubmitQueue lifecycle states, controllers, internal topics, and their tests to land terminology. Preserve Runway
MergeRequest,MergeStep,MergeResult, merge controllers, extensions, configuration, and merge topic names, with translation at the validation, land-dispatch, and result-signal boundaries.Preserve every merge strategy mapping, including
PROMOTE.Test Plan
make gazellemake testIssues