Conversation
317787106
reviewed
Sep 23, 2026
|
|
||
| These commands rerun the build steps without deleting existing build caches. | ||
|
|
||
| When the script is used from a java-tron checkout, only the Dockerfile and build context are resolved relative to `docker.sh`, regardless of the current working directory. The current checkout's Java sources are not added to that context. If only `docker.sh` was downloaded, the required architecture-specific Dockerfile is downloaded into a temporary build context and removed after the build. Both paths build the remote `master` branch. |
Collaborator
There was a problem hiding this comment.
[SHOULD] Please document the standalone build limitation here. The helper downloads only the Dockerfile from develop, but the current Dockerfile still requires docker-entrypoint.sh, which is missing from the temporary build context.
The PR description already acknowledges the pending synchronization. Until that is completed, this guide should instruct users to build from a complete checkout containing the matching Dockerfiles.
- Explain that downloaded Dockerfiles require a missing docker-entrypoint.sh - Direct users to a complete checkout containing matching Dockerfiles - Document synchronization and verification requirements for standalone builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
The Docker deployment path used outdated dependencies, weak JDK verification and stale instructions, with no dedicated CI coverage.
This PR has been tested by:
bash -n) and ShellCheck passed.Follow up
developand verify standalone helper builds for both architectures.Extra details
Targets
release_v4.8.3. Untildevelopreceives the matching files, use a complete checkout for--build. Dockerfiles continue to build Java sources from remotemaster.