Skip to content

[Repo] Cleanup - #8963

Merged
0xFirekeeper merged 1 commit into
mainfrom
firekeeper/cleanup
Sep 11, 2026
Merged

0xFirekeeper merged 1 commit into
mainfrom
firekeeper/cleanup

Conversation

@0xFirekeeper

@0xFirekeeper 0xFirekeeper commented Sep 11, 2026

Copy link
Copy Markdown
Member

@coderabbitai ignore

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@0xFirekeeper
0xFirekeeper requested review from a team as code owners September 11, 2026 18:04
@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nebula Ready Ready Preview Sep 11, 2026 6:12pm UTC
thirdweb-www Ready Ready Preview Sep 11, 2026 6:12pm UTC
wallet-ui Ready Ready Preview Sep 11, 2026 6:12pm UTC
2 Skipped Deployments
Project Deployment Actions Updated
docs-v2 Skipped Skipped Sep 11, 2026 6:12pm UTC
thirdweb_playground Skipped Skipped Sep 11, 2026 6:12pm UTC

@vercel
vercel Bot temporarily deployed to Preview – docs-v2 September 11, 2026 18:04 Inactive
@vercel
vercel Bot temporarily deployed to Preview – thirdweb_playground September 11, 2026 18:04 Inactive
@changeset-bot

changeset-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 07690b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added Dashboard Involves changes to the Dashboard. Ecosystem Portal Involves changes to the Ecosystem Portal labels Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 933cd1e9-4361-4087-95ff-08b8aea1b96b

📥 Commits

Reviewing files that changed from the base of the PR and between 5fa86f6 and 07690b0.

📒 Files selected for processing (17)
  • apps/dashboard/src/@/actions/billing.ts
  • apps/dashboard/src/@/actions/team/acceptInvite.ts
  • apps/dashboard/src/@/actions/team/deleteTeam.ts
  • apps/dashboard/src/@/actions/team/sendTeamInvite.ts
  • apps/dashboard/src/@/api/project/projects.ts
  • apps/dashboard/src/@/api/team/audit-log.ts
  • apps/dashboard/src/@/api/team/dedicated-support.ts
  • apps/dashboard/src/@/api/team/verified-domain.ts
  • apps/dashboard/src/app/(app)/api/testnet-faucet/claim/route.ts
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/ecosystem/create/actions/create-ecosystem.ts
  • apps/dashboard/src/app/(app)/team/[team_slug]/(team)/~/settings/general/updateTeam.ts
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/ai/api/fetchWithAuthToken.ts
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/ai/api/session.ts
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/ai/chat/history/ChatHistoryPage.stories.tsx
  • apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/tokens/create/token/launch/launch-token.tsx
  • apps/nebula/src/app/(app)/chat/history/ChatHistoryPage.stories.tsx
  • apps/wallet-ui/src/lib/chains.ts

Included review availability: Your plan provides up to 5 included reviews per hour; 2 remain after this review.


Walkthrough

The changes encode dynamic API path segments across dashboard and wallet requests. The faucet route validates chainId before building a transfer URL. AI server-only enforcement and UUID-based story fixtures are also updated.

Changes

API input safety

Layer / File(s) Summary
API path parameter encoding
apps/dashboard/src/@/actions/*, apps/dashboard/src/@/api/*, apps/dashboard/src/app/(app)/team/.../create-ecosystem.ts, apps/dashboard/src/app/(app)/team/.../updateTeam.ts
Team, project, invite, domain, and session identifiers are percent-encoded before insertion into API paths.
Faucet chain ID validation
apps/dashboard/src/app/(app)/api/testnet-faucet/claim/route.ts
The route rejects invalid chain IDs with HTTP 400 and uses the validated string in the Engine transfer path.
Client and server boundary updates
apps/dashboard/src/app/(app)/team/.../ai/api/*, apps/dashboard/src/app/(app)/team/.../ChatHistoryPage.stories.tsx, apps/nebula/src/app/(app)/chat/history/ChatHistoryPage.stories.tsx, apps/dashboard/src/app/(app)/team/.../launch-token.tsx, apps/wallet-ui/src/lib/chains.ts
The AI API uses server-only; session, contract, and chain path segments are encoded; story fixtures use crypto.randomUUID().

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~12 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 07690

The input-safety updates do not leave an evidenced merge-blocking risk.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided. The required reviewer notes and testing information are missing. Add the required issue tag when applicable, reviewer notes, and a description of how to test the URL encoding and faucet validation changes.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 21 functions across 17 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title uses the generic term "Cleanup" and does not identify the main changes, which are URL encoding updates, input validation, and server-only enforcement. Replace the title with a concise summary, such as "[Repo] Fix URL encoding and input validation".
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch firekeeper/cleanup

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
@thirdweb-dev/nexus (esm) 105.66 KB (0%)
@thirdweb-dev/nexus (cjs) 319.47 KB (0%)

@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.86%. Comparing base (5fa86f6) to head (07690b0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8963      +/-   ##
==========================================
+ Coverage   43.83%   43.86%   +0.02%     
==========================================
  Files         920      920              
  Lines       17639    17639              
  Branches     5193     5193              
==========================================
+ Hits         7732     7737       +5     
+ Misses       8588     8584       -4     
+ Partials     1319     1318       -1     
Flag Coverage Δ
packages 43.86% <ø> (+0.02%) ⬆️
see 3 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0xFirekeeper
0xFirekeeper merged commit efafb6f into main Sep 11, 2026
25 checks passed
@0xFirekeeper
0xFirekeeper deleted the firekeeper/cleanup branch September 11, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. Ecosystem Portal Involves changes to the Ecosystem Portal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant