P20 drc - convert the rc module to only use the sink/source api - #11001
Open
piotrhoppeintel wants to merge 2 commits into
Open
P20 drc - convert the rc module to only use the sink/source api#11001piotrhoppeintel wants to merge 2 commits into
piotrhoppeintel wants to merge 2 commits into
Conversation
piotrhoppeintel
requested review from
a team,
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
July 15, 2026 07:30
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.
Converts the DRC module processing path from the legacy audio_stream buffer API to the sof_source/sof_sink API, and adds a dedicated cmocka process-level test to validate the new data flow.
Changes:
- Update DRC processing entrypoint to use
sof_source/sof_sinkand circular-buffer views (cir_buf_source/cir_buf_sink). - Refactor DRC kernels (generic + HiFi4) to operate on circular-buffer pointers rather than
audio_streamhelpers. - Add a new cmocka
drc_processunit test and embed coefficient blobs for enabled / passthrough modes.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/cmocka/src/audio/drc/drc_process.c | New cmocka test that instantiates the module adapter and directly exercises cd->drc_func() with circular-buffer views. |
| test/cmocka/src/audio/drc/cmocka_drc_coef.h | Adds generated DRC configuration blobs used by the new process test. |
| test/cmocka/src/audio/drc/CMakeLists.txt | Adds the drc_process test target and a small static audio_for_drc library to satisfy module dependencies. |
| src/audio/drc/drc_hifi4.c | Updates passthrough + delay/processing routines to use cir_buf_* sources/sinks and wrapping. |
| src/audio/drc/drc_generic.c | Same as above for the generic implementation; adds memcpy_s include usage. |
| src/audio/drc/drc.h | Updates public DRC function signature to cir_buf_source/cir_buf_sink and stores channel count in drc_comp_data. |
| src/audio/drc/drc.c | Switches module interface to .process and implements source/sink acquire/commit flow. |
lyakh
reviewed
Jul 16, 2026
|
|
||
| cmocka_test(drc_process | ||
| drc_process.c | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Done. Test moved to the Ztest framework.
piotrhoppeintel
changed the title
piotrhoppeintel
force-pushed
the
p20-drc
branch
2 times, most recently
from
September 2, 2026 12:27
cd35aa4 to
1804c1e
Compare
Contributor
Author
|
All comments have been addressed. @lyakh please review. |
PR 11001: test resultsRun date: 2026-09-03 13:03 UTC Tested commit: 2633f8f06e25714a1f9d5566718cf3697c6db6f1
|
piotrhoppeintel
force-pushed
the
p20-drc
branch
from
September 3, 2026 07:21
1804c1e to
b70c5db
Compare
lyakh
reviewed
Sep 3, 2026
| } | ||
|
|
||
| if (!td->params.passthrough && output != expected) | ||
| td->diff_count++; |
Collaborator
There was a problem hiding this comment.
is this verifying, that since the input chirp was neither too quiet nor too loud it should pass unchanged?
Contributor
Author
There was a problem hiding this comment.
Not exactly. It has two meanings. With active DRC, a change is expected, while in pass-through mode, any change means a failure.
Add native_sim Ztest coverage for two-channel DRC processing. Cover S16, S24, and S32 pass-through and enabled configurations through component creation, configuration, preparation, and processing. Add the minimal SOF allocator and context support required by the standalone test application while keeping existing CMocka tests and production sources unchanged. Signed-off-by: Piotr Hoppe <piotr.hoppe@intel.com>
Convert the DRC module from the legacy audio_stream processing API to the modern sof_source/sof_sink API.
piotrhoppeintel
force-pushed
the
p20-drc
branch
from
September 3, 2026 12:14
b70c5db to
2633f8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the DRC module from the legacy audio_stream processing API
to the modern sof_source/sof_sink API.