feat: enable customer installation of amcheck (PSQL-1327) - #2240
Merged
Conversation
PostgreSQL Extension Dependency Analysis: PR #2240
SummaryNo extensions had dependencies with MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Extension DependenciesPostgreSQL 17 Extension DependenciesOrioleDB 17 Extension Dependencies |
PostgreSQL Package Dependency Analysis: PR #2240
SummaryNo packages had MAJOR version updates. Full Analysis ResultsPostgreSQL 15 Dependency ChangesExtracting PostgreSQL 15 dependencies...
Runtime Closure Size
Raw Dependency ClosurePostgreSQL 17 Dependency ChangesExtracting PostgreSQL 17 dependencies...
Runtime Closure Size
Raw Dependency Closure |
Collaborator
Author
|
#2240 (comment) |
|
Backup Testing section in current PR description has an item that does not sound reasonable to me.
Assuming old and new correspond to Postgres 15 and 17, this is not an easy task. I do not yet know what options do our users have for restoring but the most probable methods do not work. Postgres 15 was shipped with amcheck Official support for downgrading to an older major version is explicitly not supported by PostgreSQL via standard restore tools. One can always try to manually fix issues in the dump and attempt to restore. It is highly likely that many iterations of edits and retries are required until you can actually downgrade your database version. |
Collaborator
Author
|
I just used the issue template. I only wrote the first two paragraphs. |
Collaborator
Author
|
@hanefi can you review wether amcheck is safe to enable for users? |
Collaborator
|
I am taking over the review and testing of this PR |
samrose
force-pushed
the
psql-1327-enable-amcheck
branch
2 times, most recently
from
August 18, 2026 21:05
fbb6fd8 to
ac4b183
Compare
samrose
marked this pull request as ready for review
August 18, 2026 21:06
Collaborator
|
Will document next step of supadev smoke testing prior requesting review |
samrose
force-pushed
the
psql-1327-enable-amcheck
branch
2 times, most recently
from
August 21, 2026 15:04
44432cb to
77b6c1f
Compare
soedirgo
reviewed
Aug 21, 2026
samrose
force-pushed
the
psql-1327-enable-amcheck
branch
3 times, most recently
from
August 26, 2026 15:12
aa7d360 to
b4d6400
Compare
This comment has been minimized.
This comment has been minimized.
samrose
force-pushed
the
psql-1327-enable-amcheck
branch
from
August 27, 2026 16:31
b4d6400 to
e7101d2
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
latest changes as of this writing in this PR confirmed in staging |
samrose
force-pushed
the
psql-1327-enable-amcheck
branch
from
August 27, 2026 20:35
e7101d2 to
813ae9d
Compare
soedirgo
reviewed
Aug 28, 2026
soedirgo
reviewed
Aug 28, 2026
soedirgo
approved these changes
Aug 28, 2026
Co-authored-by: Bobbie Soedirgo <31685197+soedirgo@users.noreply.github.com>
samrose
force-pushed
the
psql-1327-enable-amcheck
branch
from
August 31, 2026 11:52
a90f098 to
d53c8a1
Compare
samrose
enabled auto-merge
August 31, 2026 11:52
samrose
disabled auto-merge
August 31, 2026 11:53
samrose
changed the title
Collaborator
|
his issue with be handed off to managed postgres team to make decisions about how to handle upgrades, pause/restore etc cc @KevinBrolly |
mmlb
marked this pull request as draft
August 31, 2026 15:23
Collaborator
Author
|
Taking over drive to merge this. Reviewing and testing upgrade. |
Collaborator
Author
|
Pause/restore risk is low: Supabase doesn't support restoring a project onto a different major Postgres version, so the amcheck 1.3↔1.4 version-pin issue (dump/restore across 15↔17) doesn't apply there — pause/resume is same-version stop/start only. The pg_upgrade path is the real risk; tracked separately. |
Collaborator
Author
|
Upgrade risk: PG15 ships amcheck 1.3, PG17 ships 1.4. pg_upgrade runs Fix: add |
Restores the KNOWN LIMITATION comment in after-create.sql and the amcheck-upgrade.nix VM test removed earlier in this branch's history. Adds a hard assertion (previously just a printed note) that postgres can call amcheck 1.4's PG17-only bt_index_check overload after a real 15 -> 17 pg_upgrade — this fails today, since the harness's bare pg_upgrade never runs the drop-before/recreate-after fix that lives in production's initiate.sh. Expected red until that gap is closed, either via a supautils after-update hook or by making this harness replay the real admin-API scripts instead of a bare pg_upgrade.
Collaborator
Author
|
Restored |
This comment has been minimized.
This comment has been minimized.
Drops amcheck before the pg_upgrade specialisation switch and recreates it fresh after, mirroring initiate.sh's drop-before/recreate-after mechanism without invoking that script (this harness runs a bare pg_upgrade, not the real admin-API scripts). Verified locally: this closes the permission gap completely — postgres gets full EXECUTE on every amcheck function, including the PG17-only 1.4 overload that previously failed with permission denied.
Reuses the existing EXTENSIONS_TO_DISABLE drop-before/recreate-after mechanism (already used for pg_graphql, pg_stat_monitor, pg_backtrace) instead of letting amcheck survive pg_upgrade via an in-place ALTER EXTENSION UPDATE. 15 ships amcheck 1.3, 17 ships 1.4; an in-place update leaves the 1.4-only functions ungranted since supautils has no after-update hook. Dropping and recreating goes through the same after-create grant path a customer's own install would, closing the gap.
Collaborator
Author
|
Fix pushed: added |
brainrake
changed the title
brainrake
marked this pull request as ready for review
September 7, 2026 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes PSQL-1327
What kind of change does this PR introduce?
Moves the amcheck contrib extension into
supautils.privileged_extensionssocustomers can install it, pinned to the
pg_catalogschema.Additional context
amcheck was on supautils' "may be unsafe" list based on upstream
caution around physical data
structure exposure. Enabling it turned out to require the schema pin:
supabase_admin, whose search_pathstarts with
public.ALTER DEFAULT PRIVILEGES ... IN SCHEMA public(initial-schema.sql) grantsEXECUTE to
postgres, anon, authenticated, service_role. Those are explicitgrants, so amcheck's
REVOKE ALL FROM PUBLICdoes not strip them.verify_nbtree.c:"Intentionally not checking permissions" so EXECUTE means "check any index in
the database".
Verified before the pin:
set role anon; select bt_index_check('auth.users_pkey')succeeded. That would have exposed
bt_index_parent_check()(ShareLock, blockswrites) and
verify_heapam()to unauthenticated PostgREST callers. Inpg_catalogthe equivalent rule grants to
postgresonly with grant option, so customers canstill share it deliberately.
Tests
nix/tests/sql/amcheck.sql— placement, override enforcement (with schema publicis redirected), the four-role privilege matrix, and the functional path.
nix/ext/tests/amcheck-upgrade.nix15→17pg_upgradepreserves schema andgrants, including through the 1.3→1.4 extension update that creates new functions.
Action Items
supadev trigger-smoke-tests <PR> engines extensionsupgradetarget covers pause-on-old/restore-on-new;single-file backup/restore still manual