Use wget healthchecks on slim Elixir images - #6386
Conversation
docker.io realtime/analytics/pooler still probe with curl; slim images ship busybox wget instead. Keep the Logflare run.sh override for both families. Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02c402d8d9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export function legacyUsesSlimRuntime(image: string): boolean { | ||
| return image.includes(SLIM_IMAGE_REPO) || image.startsWith("supabase/cli/"); |
There was a problem hiding this comment.
When a slim image enters the real start pipeline, this predicate receives the resolved candidate rather than the requested image. legacyGetRegistryImageUrlCandidates() reduces ghcr.io/supabase/cli/realtime:<tag> to candidates such as public.ecr.aws/supabase/realtime:<tag> and ghcr.io/supabase/realtime:<tag>, and start.handler.ts passes that resolved name into the service builder. A successful mirrored pull therefore makes this return false, causing the slim container to run the unavailable curl healthcheck and remain unhealthy; the added unit tests miss this by passing the original GHCR name directly. Preserve the /supabase/cli/ namespace during resolution or carry the slim-runtime identity separately from the resolved image reference.
Useful? React with 👍 / 👎.
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@02c402d8d91cf670706af971cfc866cbcb8363caPreview package for commit |
1 participant
Summary
ghcr.io/supabase/cli/…) vialegacyUsesSlimRuntime.wget -q --spideron slim (busybox) and keep curl on docker.io.run.shoverride stays for both families.Depends on slim-services#287 publishing wget-on-PATH images. Do not merge until those force rebuilds finish.
Test plan
legacyUsesSlimRuntimeand the three Elixir specssupabase startagainst slim realtime/analytics/pooler becomes healthy via wgetMade with Cursor