Support VAN_ALBADA_EDGE limiter for turbulence and species - #2908
Closed
ManasBagul23 wants to merge 1 commit into
Closed
ManasBagul23 wants to merge 1 commit into
ManasBagul23 wants to merge 1 commit into
Conversation
Setting SLOPE_LIMITER_TURB or SLOPE_LIMITER_SPECIES to VAN_ALBADA_EDGE aborted with "Unknown limiter type", because CScalarSolver always computed point-based limiters. Apply the edge limiter during the MUSCL reconstruction in Upwind_Residual, the same way the flow solvers do, and skip the point limiter computation for it. The LIMITER volume outputs of the scalar solvers are not registered for VAN_ALBADA_EDGE, as for the flow solver, since there are no point limiter values to write.
There was a problem hiding this comment.
🟡 Changes recommended
Add regression coverage for VAN_ALBADA_EDGE in scalar turbulence and species cases.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds VAN_ALBADA_EDGE support for turbulence and species scalar MUSCL reconstruction.
Changes:
- Applies edge-based Van Albada limiting in
CScalarSolver. - Adjusts limiter output registration.
- Updates limiter configuration documentation.
File summaries
| File | Description |
|---|---|
SU2_CFD/src/output/CFlowOutput.cpp |
Adjusts limiter output handling. |
SU2_CFD/include/solvers/CScalarSolver.inl |
Implements scalar edge-limiter reconstruction. |
config_template.cfg |
Removes the outdated limiter restriction. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+274
to
+276
| if (van_albada) { | ||
| Project_Grad_i *= LimiterHelpers<>::vanAlbadaFunction(Project_Grad_i, U_ij, EPS); | ||
| Project_Grad_j *= LimiterHelpers<>::vanAlbadaFunction(Project_Grad_j, U_ij, EPS); |
6 tasks
Member
|
Can be done #2878 more easily |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Setting
SLOPE_LIMITER_TURBorSLOPE_LIMITER_SPECIEStoVAN_ALBADA_EDGEcurrently aborts withUnknown limiter type., becauseCScalarSolveralways computes point-based limiters.CScalarSolver::Upwind_Residual, usingLimiterHelpers<>::vanAlbadaFunctionasCEulerSolverandCIncEulerSolverdo, andSetSolution_Limiteris skipped for it.LIMITERvolume outputs of the turbulence and species solvers are not registered forVAN_ALBADA_EDGE, as for the flow solver, since there are no point limiter values.config_template.cfgno longer says thatSLOPE_LIMITER_TURBexcludesVAN_ALBADA_EDGE.Tested with
TestCases/rans/flatplate/turb_SA_flatplate_species.cfgwithMUSCL_TURB= YESandMUSCL_SPECIES= YES, 50 iterations, serial and on 2 MPI ranks: the case runs withVAN_ALBADA_EDGEfor both scalars and the residuals differ from bothVENKATAKRISHNANandNONE. The residual history withVENKATAKRISHNANis identical to develop.I did not add a regression test yet, I can add one if you would like one for this.
Related Work
Closes #2416.
PR Checklist
pre-commit run --allto format old commits.