Match maxHF history header in SU2_PY history map - #2906
Closed
ManasBagul23 wants to merge 2 commits into
Closed
ManasBagul23 wants to merge 2 commits into
ManasBagul23 wants to merge 2 commits into
Conversation
SU2_CFD writes the MAXIMUM_HEATFLUX history field with the header "maxHF" (and "d[maxHF]" for its derivative), but historyMap.py expects "MaxHF". read_history matches headers exactly, so MAXIMUM_HEATFLUX was never found in the history file and could not be used as an objective or constraint from the Python scripts.
There was a problem hiding this comment.
🟡 Changes recommended
Update the remaining time-averaged maximum-heat-flux mappings.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates Python history mappings to match SU2_CFD’s lowercase maxHF header naming.
Changes:
- Corrects direct maximum heat-flux and derivative mappings.
- Time-averaged mappings still require matching updates.
File summaries
| File | Summary |
|---|---|
SU2_PY/SU2/io/historyMap.py |
Direct mappings are corrected, but time-averaged entries still use MaxHF instead of maxHF (moderate, 3 votes). |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "in MARKER_MONITORING", | ||
| "GROUP": "HEAT", | ||
| "HEADER": "MaxHF", | ||
| "HEADER": "maxHF", |
The time-averaged fields derive their headers from the base field name, so SU2_CFD writes tavg[maxHF] and dtavg[maxHF], not tavg[MaxHF] and dtavg[MaxHF].
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
SU2_CFD writes the
MAXIMUM_HEATFLUXhistory field with the headermaxHF(andd[maxHF]for its derivative) since cc9e452, butSU2_PY/SU2/io/historyMap.pystill expectsMaxHF. The time-averaged fields derived from it are written astavg[maxHF]anddtavg[maxHF], which the map also listed withMaxHF.read_historymatches headers exactly, soMAXIMUM_HEATFLUXis never found and cannot be used as an objective or constraint from the Python scripts.Checked with a laminar flat plate run (history output
HEAT): on developSU2.io.read_historyreturnsTOTAL_HEATFLUXbut notMAXIMUM_HEATFLUX; with this change both are found, andTAVG_MAXIMUM_HEATFLUXandTAVG_D_MAXIMUM_HEATFLUXare mapped fortavg[maxHF]anddtavg[maxHF]headers.Related Work
Closes #2916.
PR Checklist
pre-commit run --allto format old commits.