Add retries to download commands in installers scripts and always checks versions to ensure it is working - #79
Merged
Conversation
…cks versions to ensure it is working Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
scholzj
approved these changes
Sep 10, 2026
scholzj
left a comment
scholzj
left a comment
Member
There was a problem hiding this comment.
No need to change it just because of me. But why do we use sometimes curl and sometimes wget?
Member
Author
No idea, I guess someone in the past created script X with curl and someone else used wget for script Y? I don't think there is any specific reason. I can unite it |
Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
Member
Author
|
@scholzj I changed wget to curl everywhere |
scholzj
approved these changes
Sep 11, 2026
Frawless
added a commit
that referenced
this pull request
Sep 11, 2026
…cks versions to ensure it is working (#79) * Add retries to download commands in installers scripts and always checks versions to ensure it is working Signed-off-by: Jakub Stejskal <xstejs24@gmail.com> * Use curl for downloading tools Signed-off-by: Jakub Stejskal <xstejs24@gmail.com> --------- Signed-off-by: Jakub Stejskal <xstejs24@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR improves current installers scripts to be more robust and fail fast.
Checklist