Skip to content

fix: avoid integer overflow #14972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 1 commit into from
Sep 4, 2026
+33 −20
Merged

fix: avoid integer overflow #14972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/hypergeometric/logpmf/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,19 @@ double stdlib_base_dists_hypergeometric_logpmf( const double x, const int32_t N,
double lnum;
double maxs;
double mins;
double dn;
double dK;
double dN;

if ( stdlib_base_is_nan( x ) || N < 0 || K < 0 || n < 0 || K > N || n > N ) {
return 0.0/0.0; // NaN
}

mins = stdlib_base_max( 0, n+K-N );
maxs = stdlib_base_min( K, n );
dn = (double)n;
dN = (double)N;
dK = (double)K;
mins = stdlib_base_max( 0.0, dn+dK-dN );
maxs = stdlib_base_min( dK, dn );

if ( stdlib_base_is_nonnegative_integer( x ) && mins <= x && x <= maxs ) {
lnum = stdlib_base_factorialln( n ) + stdlib_base_factorialln( K ) + stdlib_base_factorialln( N-n ) + stdlib_base_factorialln( N-K );
Expand Down
10 changes: 8 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/hypergeometric/pmf/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,19 @@ double stdlib_base_dists_hypergeometric_pmf( const double x, const int32_t N, co
double lpmf;
double maxs;
double mins;
double dn;
double dK;
double dN;

if ( stdlib_base_is_nan( x ) || N < 0 || K < 0 || n < 0 || K > N || n > N ) {
return 0.0/0.0; // NaN
}

mins = stdlib_base_max( 0, n+K-N );
maxs = stdlib_base_min( K, n );
dn = (double)n;
dN = (double)N;
dK = (double)K;
mins = stdlib_base_max( 0.0, dn+dK-dN );
maxs = stdlib_base_min( dK, dn );

if ( stdlib_base_is_nonnegative_integer( x ) && mins <= x && x <= maxs ) {
lnum = stdlib_base_factorialln( n ) + stdlib_base_factorialln( K ) + stdlib_base_factorialln( N-n ) + stdlib_base_factorialln( N-K );
Expand Down
33 changes: 17 additions & 16 deletions lib/node_modules/@stdlib/stats/base/dists/hypergeometric/quantile/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,14 @@
* double y = stdlib_base_dists_hypergeometric_quantile( 0.4, 40, 20, 10 );
* // returns 5
*/
double stdlib_base_dists_hypergeometric_quantile(
const double p,
const int32_t N,
const int32_t K,
const int32_t n
) {
double stdlib_base_dists_hypergeometric_quantile( const double p, const int32_t N, const int32_t K, const int32_t n ) {
double upper;
double lower;
double prob;
int32_t upper;
int32_t lower;
int32_t x;
double dn;
double dK;
double dN;
double x;

if (
stdlib_base_is_nan( p ) ||
Expand All @@ -60,23 +58,26 @@ double stdlib_base_dists_hypergeometric_quantile(
return 0.0 / 0.0;
}

lower = stdlib_base_max( 0, n + K - N );
upper = stdlib_base_min( n, K );
dn = (double)n;
dN = (double)N;
dK = (double)K;
lower = stdlib_base_max( 0.0, dn+dK-dN );
upper = stdlib_base_min( dn, dK );

if ( p == 0.0 ) {
return (double)lower;
return lower;
}
if ( p == 1.0 ) {
return (double)upper;
return upper;
}

x = lower;
while ( x <= upper ) {
prob = stdlib_base_dists_hypergeometric_cdf( (double)x, N, K, n );
prob = stdlib_base_dists_hypergeometric_cdf( x, N, K, n );
if ( prob > p ) {
break;
}
x += 1;
x += 1.0;
}
return (double)x;
return x;
}