Skip to content

test: migrate stats/base/dists/exponential/stdev to ULP-based assertions - #14936

Merged
kgryte merged 1 commit into
developfrom
kgryte/ulp-exponential-stdev
Sep 4, 2026
Merged

test: migrate stats/base/dists/exponential/stdev to ULP-based assertions#14936
kgryte merged 1 commit into
developfrom
kgryte/ulp-exponential-stdev

Conversation

@kgryte

@kgryte kgryte commented Sep 3, 2026

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

The ULP bound was tightened to the minimum integer that passes over the full fixture set. All 50 fixture values match the reference output exactly, so the minimum required ULP is:

  • test/test.js: 0 ULP
  • test/test.native.js: 0 ULP

The suite was run twice at the final bound to confirm determinism (no FMA/arch flakiness).

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance.

This PR was authored primarily by Claude Code: it converted the tolerance-based fixture assertions to ULP-based assertions and measured the minimum passing ULP bound over the full fixture set.


@stdlib-js/reviewers

🤖 Generated with Claude Code

https://claude.ai/code/session_019Ba3VZAiNQUyCZRWJuJQqw


Generated by Claude Code

…tions

Migrate the standard deviation tests for the exponential distribution
from relative tolerance comparisons to ULP-based assertions using
`@stdlib/assert/is-almost-same-value`.

Ref: #11352

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019Ba3VZAiNQUyCZRWJuJQqw
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Sep 3, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/exponential/stdev $\\color{green}161/161$
$\\color{green}+100.00\\%$
$\\color{green}8/8$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}161/161$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte added the Tests Pull requests specifically adding tests. label Sep 4, 2026
@kgryte
kgryte marked this pull request as ready for review September 4, 2026 02:05
@kgryte
kgryte requested a review from a team September 4, 2026 02:05
@kgryte
kgryte merged commit e4ae867 into develop Sep 4, 2026
66 checks passed
@kgryte
kgryte deleted the kgryte/ulp-exponential-stdev branch September 4, 2026 02:06
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. Tests Pull requests specifically adding tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants