test: migrate stats/incr/mmpe to ULP-based assertions - #14931
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AmuE4qxqzr54jsqv5pq1rk
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
marked this pull request as ready for review
September 4, 2026 05:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a part of #11352.
Description
This pull request:
stats/incr/mmpefrom relative tolerance (EPS-scaled) assertions to ULP-based assertions using@stdlib/assert/is-almost-same-value.Details:
test/test.jsis the only test file in the package containing computed-tolerance assertions; notest.native.jsexists.abs/EPSdelta <= tolcomparison (and the associateddelta/tollocals and requires) witht.strictEqual( isAlmostSameValue( actual, expected[i], N ), true, 'returns expected value' );.N = 64and loweringNuntil the smallest integer which still passes across every fixture value:the accumulator function computes a moving mean percentage error incrementally: 1 ULP (passes at1; fails at0with 3 failing assertions; previous tolerance was1.0 * EPS).make lint-javascript-tests TESTS_FILTER=".*/stats/incr/mmpe/.*"is clean, and the only changed file islib/node_modules/@stdlib/stats/incr/mmpe/test/test.js.Related Issues
This pull request has the following related issues:
math/base/specialpackages from relative tolerance testing to ULP difference testing (tracking issue) #11352Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code, which studied prior ULP migrations in this repository (including the sibling package
stats/incr/mpe), applied the same idiom here, and empirically searched for the minimum passing ULP bound.@stdlib-js/reviewers
🤖 Generated with Claude Code
https://claude.ai/code/session_01AmuE4qxqzr54jsqv5pq1rk
Generated by Claude Code