Skip to content

test: migrate stats/base/dists/levy/logcdf to ULP-based assertions - #14929

Draft
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-stats-base-dists-levy-logcdf
Draft

test: migrate stats/base/dists/levy/logcdf to ULP-based assertions#14929
Planeshifter wants to merge 1 commit into
developfrom
philipp/ulp-stats-base-dists-levy-logcdf

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Resolves a part of #11352.

Description

What is the purpose of this pull request?

This pull request:

  • migrates the stats/base/dists/levy/logcdf test suite (test.logcdf.js, test.factory.js, test.native.js) from the relative-tolerance (EPS/abs-based) idiom to @stdlib/assert/is-almost-same-value-based ULP difference assertions.
  • determines the tightest ULP bound per test body by computing the exact ULP difference (via @stdlib/number/float64/base/ulp-difference) between the actual and expected fixture values, for both the JavaScript implementation and the built native (C) addon, and confirms the result is deterministic across repeated runs.
  • final ULP constant used: ULP = 0 (exact match) for all three converted files (test.logcdf.js, test.factory.js, test.native.js), across all three fixture sets (positive_mean, negative_mean, large_variance).

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Only the test files in stats/base/dists/levy/logcdf/test/ were changed; no package.json changes were needed. make test TESTS_FILTER=".*/stats/base/dists/levy/logcdf/.*" passes for all four test files (test.js: 3/3, test.logcdf.js: 3016/3016, test.factory.js: 3020/3020, test.native.js: 3016/3016, the latter run against a locally built native addon), run twice to confirm determinism, and npx eslint reports no lint errors on the changed files.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written primarily by Claude Code, including computing the tightest ULP bounds and applying the test-file edits.


@stdlib-js/reviewers


🤖 Generated with Claude Code

https://claude.ai/code/session_01FNJXXvVVMrtVcU25HhpuJ7


Generated by Claude Code

Replaces relative tolerance (EPS-based) test assertions with
`isAlmostSameValue` ULP-based assertions in `test.logcdf.js`,
`test.factory.js`, and `test.native.js`.

Resolves a part of #11352

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FNJXXvVVMrtVcU25HhpuJ7

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: skipped
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Good First PR A pull request resolving a Good First Issue. labels Sep 3, 2026
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/levy/logcdf $\\color{green}311/311$
$\\color{green}+100.00\\%$
$\\color{green}23/23$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}311/311$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants