Skip to content

feat: add C implementation for stats/base/ndarray/snanmean - #14562

Open
Siddhram wants to merge 6 commits into
stdlib-js:developfrom
Siddhram:feat/snanmean
Open

feat: add C implementation for stats/base/ndarray/snanmean#14562
Siddhram wants to merge 6 commits into
stdlib-js:developfrom
Siddhram:feat/snanmean

Conversation

@Siddhram

Copy link
Copy Markdown
Contributor

Resolves a part of #14034

Description

What is the purpose of this pull request?

This pull request:

  • feat: add C implementation for stats/base/ndarray/snanmean

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@Siddhram
Siddhram requested a review from a team August 23, 2026 13:03
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Aug 23, 2026
@stdlib-bot

stdlib-bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/snanmean $\\color{green}176/176$
$\\color{green}+0.00\\%$
$\\color{green}7/7$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}176/176$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

Comment thread lib/node_modules/@stdlib/stats/base/ndarray/snanmean/README.md
@ujjwalv01

Copy link
Copy Markdown
Contributor

Everthing else looks good!

@Siddhram

Copy link
Copy Markdown
Contributor Author

Everthing else looks good!

I've fixed the equation. Please take another look.

@ujjwalv01

Copy link
Copy Markdown
Contributor

Looks good to me!

cc : @kgryte

Comment thread lib/node_modules/@stdlib/stats/base/ndarray/snanmean/README.md Outdated

@0PrashantYadav0 0PrashantYadav0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the suggested changes

@0PrashantYadav0 0PrashantYadav0 added C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Aug 25, 2026
@0PrashantYadav0

Copy link
Copy Markdown
Member

Why you revert the expected changes? You can refer #14628 if getting any error.

Sachinn-64
Sachinn-64 previously approved these changes Aug 26, 2026

@Sachinn-64 Sachinn-64 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Sachinn-64 Sachinn-64 added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Aug 26, 2026
@0PrashantYadav0

Copy link
Copy Markdown
Member

@Sachinn-64, shouldn't benchmark.native.js be updated to create a random uniform array using @stdlib/random/uniform?

@Sachinn-64

Copy link
Copy Markdown
Member

@Sachinn-64, shouldn't benchmark.native.js be updated to create a random uniform array using @stdlib/random/uniform?

Refer https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/stats/base/ndarray/snanmax/benchmark/benchmark.native.js

@0PrashantYadav0

Copy link
Copy Markdown
Member

I think https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/stats/base/ndarray/snanmax/benchmark/benchmark.native.js this one also need to changes the benchmark implementation here.

@kgryte need your input here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. Needs Review A pull request which needs code review. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants