[6.x] Honour the COMPOSER env var when locating composer.json and its lock file - #15362
Merged
Merged
Conversation
…ock file Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cgc3YjCDAFAX66aHANrFEB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where Statamic would error when the
COMPOSERenvironment variable points Composer at a differentcomposer.jsonfile (eg.COMPOSER=composer.local.json).This was happening because Statamic hard-coded
composer.jsonandcomposer.lockpaths. Composer names the lock file after the configured JSON file (composer.local.json→composer.local.lock), soVersion::get()couldn't find a lock file and threw on every request, andstatamic:installreported a missingpre-update-cmdhook because it was reading acomposer.jsonthat no longer existed.This PR fixes it by resolving the filenames the same way Composer does.
Json::filename()reads theCOMPOSERenvironment variable (falling back tocomposer.json) andLock::filename()derives the lock filename from it. Everywhere Statamic previously assumedcomposer.jsonorcomposer.locknow goes through these, including the update scripts, starter kit installer/exporter andmake:addon.Fixes #10592