You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Address #2577under the assumption that symmetry is preferrable (between vector/ize-only and lexical-only paths for f.A.R.R.)
In other words, rather than better dressing the error mentioned in the issue (no vector/ize provided => illegal arg exception), it accepts a findAndRerank with the lexical part only in $hybrid, executes that leg of the retrieval, and submits those results to the reranker.
Note: this PR is kept intentionally clear of fixing the absence of "rerankOn" (these two errors are close to each other). This is to avoid overlapping with #2578 which deals with that issue. If that other ever gets merged, it might be a good idea to add a test to this one for the case with lexical-only and no rerankOn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Address #2577 under the assumption that symmetry is preferrable (between vector/ize-only and lexical-only paths for f.A.R.R.)
In other words, rather than better dressing the error mentioned in the issue (no vector/ize provided => illegal arg exception), it accepts a findAndRerank with the lexical part only in $hybrid, executes that leg of the retrieval, and submits those results to the reranker.
Note: this PR is kept intentionally clear of fixing the absence of "rerankOn" (these two errors are close to each other). This is to avoid overlapping with #2578 which deals with that issue. If that other ever gets merged, it might be a good idea to add a test to this one for the case with lexical-only and no rerankOn.
Which issue(s) this PR fixes:
Fixes #2577
Checklist