feat(rabbitmq): add roles support to rabbitmq credential resource - #1726
Closed
SerseusWasTaken wants to merge 3 commits into
Closed
feat(rabbitmq): add roles support to rabbitmq credential resource#1726SerseusWasTaken wants to merge 3 commits into
SerseusWasTaken wants to merge 3 commits into
Conversation
Relates to STACKITTPR-815
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
SerseusWasTaken
added
ignore-stale
and removed
Stale
marceljk
reviewed
Sep 8, 2026
Comment on lines
+285
to
+303
| if !utils.IsUndefined(model.Roles) { | ||
| var roles []string | ||
| diags = model.Roles.ElementsAs(ctx, &roles, false) | ||
| resp.Diagnostics.Append(diags...) | ||
| if resp.Diagnostics.HasError() { | ||
| return | ||
| } | ||
|
|
||
| sdkRoles := make([]rabbitmq.CredentialsParametersRolesInner, len(roles)) | ||
| for i, r := range roles { | ||
| sdkRoles[i] = rabbitmq.CredentialsParametersRolesInner(r) | ||
| } | ||
|
|
||
| createReq = createReq.CreateCredentialsPayload(rabbitmq.CreateCredentialsPayload{ | ||
| Parameters: &rabbitmq.CredentialsParameters{ | ||
| Roles: sdkRoles, | ||
| }, | ||
| }) | ||
| } |
Contributor
There was a problem hiding this comment.
Could you move this to a dedicated toCreatePayload() function, similar like we have it in other resources? For one attribute, it might be a bit too much to have a dedicated function, but I know from the past that this can escalate quickly. This makes also testing easier :)
| _ resource.ResourceWithImportState = &credentialResource{} | ||
| _ resource.ResourceWithModifyPlan = &credentialResource{} | ||
|
|
||
| roleOptions = sdkUtils.EnumSliceToStringSlice(rabbitmq.AllowedCredentialsParametersRolesInnerEnumValues) |
Contributor
There was a problem hiding this comment.
I would suggest to move this into the Schema function, because this it only called within the function
Contributor
Author
|
Will not be merged due to open API issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds role support to
stackit_rabbitmq_credentialRelates to STACKITTPR-815 and #1708
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)